Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp3977252ybg; Sun, 7 Jun 2020 17:14:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw9hcVhlHyOdLK0En8GukYhTDHJE/tsWustgG7iYaSpeZqBB7vacuPErdrxWxlNNjI2T6Q X-Received: by 2002:a17:906:28da:: with SMTP id p26mr17910251ejd.551.1591575272160; Sun, 07 Jun 2020 17:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591575272; cv=none; d=google.com; s=arc-20160816; b=L5A/kSxJvYIa9IzBBVN1I3iI3r0CWgMWlwBJTTLU/GRoD1jusCc3BsBJ5O5FM5FDXf OQXALlsFB2n/lo6ixgFqlxly36lxmd8uOuCY9on/yU/MxI8M954hBC7wScRGZ1kfQ+MT rN7MevYZRVRDjSkQ0+XkWLXQ0vSWwm/c2avSyc18SkC0R300P0hF1MdBiSihG25H01Dt wf6674h8kVs0GzCIyoFEdwWUO9VVIvvF0PNsgYsIB11oqhuhgDztx3KoSEdem8Cr3Lzo Apu3lECoM2U9i3/zOagIFg6SU0+JbEsJsdIeb2Nd0RWoDh21XWC/jmFMqf+wGKEw3I95 gi8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=RrmBeuRFUoWocWuxmroStJkbOTiynq609HaYQ7Bye0g=; b=HJiTBBxznfazuf3vySdkQhxQyOh1dfSxcHh37OrROS9Ui5CffxAStBEwmlI1qISPhf NFhDcr4mq9atPHv2Tg+pAThiFGVGOATrOPkuLPV9PvGyE8ZINBBaXU1GSWQUA1Niys8s xcWATKW+p2zhhIlP+dkbmz8ItkXo6nbD5FEdGrCdw/CLuaIvFaTuE49cZbQTHwPLulLy 7w9yNAfN6eV+h0eWn1pFcFv/CZvM3udToyHdVxu4eoWWwATWp47UAcAD3KlYsizkzcaa NrOLQkaob+KphoLs/qKllJpd+nj42+QMEH2t4FOwMEZo+oq0FdAEz4BqWGjkf86K4Qy/ UQdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si8624065edq.423.2020.06.07.17.13.43; Sun, 07 Jun 2020 17:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbgFHAKJ (ORCPT + 99 others); Sun, 7 Jun 2020 20:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727878AbgFHAKI (ORCPT ); Sun, 7 Jun 2020 20:10:08 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC9CC08C5C3; Sun, 7 Jun 2020 17:10:08 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 905CD12741D61; Sun, 7 Jun 2020 17:10:07 -0700 (PDT) Date: Sun, 07 Jun 2020 17:10:06 -0700 (PDT) Message-Id: <20200607.171006.1687043130909899357.davem@davemloft.net> To: martin.blumenstingl@googlemail.com Cc: hauke@hauke-m.de, netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v1] net: dsa: lantiq_gswip: fix and improve the unsupported interface error From: David Miller In-Reply-To: <20200607130258.3020392-1-martin.blumenstingl@googlemail.com> References: <20200607130258.3020392-1-martin.blumenstingl@googlemail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 07 Jun 2020 17:10:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Martin Blumenstingl Date: Sun, 7 Jun 2020 15:02:58 +0200 > While trying to use the lantiq_gswip driver on one of my boards I made > a mistake when specifying the phy-mode (because the out-of-tree driver > wants phy-mode "gmii" or "mii" for the internal PHYs). In this case the > following error is printed multiple times: > Unsupported interface: 3 > > While it gives at least a hint at what may be wrong it is not very user > friendly. Print the human readable phy-mode and also which port is > configured incorrectly (this hardware supports ports 0..6) to improve > the cases where someone made a mistake. > > Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Signed-off-by: Martin Blumenstingl Looks good, applied, thank you.