Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: BU3VBX24oyMiErs/tTOubysRSi6sy5FBeEvW2U4AikIvz6FJHxEnprIAi4iwpi4BicwMm6gIfi
 jNMDPjrxD50w==
IronPort-SDR: 9UuqNA6iexNkBgKaXTVlKlbqdHcGO4iRb0L+qUAVTaDMMCNm4V5dUtiZpp7cnVcWkZpk0IFJS5
 kBB5yC15Budg==
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>
CC:     "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] fpga: dfl: Fix dead store
Thread-Topic: [PATCH 1/1] fpga: dfl: Fix dead store
Thread-Index: AQHWPEXmHXqTdFbUNkCGTs942gNbhKjN8/YA
Date:   Mon, 8 Jun 2020 01:53:46 +0000
Message-ID: <DM6PR11MB3819CCD054BC0A764AB4A57885850@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20200606210241.7459-1-trix@redhat.com>
 <20200606210241.7459-2-trix@redhat.com>
In-Reply-To: <20200606210241.7459-2-trix@redhat.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 72db9c8f-3148-4404-e392-08d80b4ec84f
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2020 01:53:46.7809
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W0sjOaaqxp3WgfyX6Vm34J3o9Q6peSSeGAQbdxdt7bUQEnBWoFat6Psh2uaFo6NYACcilaur1fKnswB/RLN1sQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2588
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: linux-fpga-owner@vger.kernel.org <linux-fpga-owner@vger.kernel.org>
> On Behalf Of trix@redhat.com
> Sent: Sunday, June 7, 2020 5:03 AM
> To: mdf@kernel.org
> Cc: linux-fpga@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Rix
> <trix@redhat.com>
> Subject: [PATCH 1/1] fpga: dfl: Fix dead store
>=20

Thanks for this patch, looks good to me, but this patch is not related to
dfl, so please remove dfl from the title to avoid confusion. : )
or maybe it can be split into two patches:
fpga: mgr: xxx
fpga: bridge: xxx

Thanks
Hao

> From: Tom Rix <trix@redhat.com>
>=20
> Using clang's scan-build/view this issue was flagged in fpga-mgr.c
>=20
>   drivers/fpga/fpga-mgr.c:585:3: warning: Value stored to 'ret' is never =
read
> [deadcode.DeadStores]
>                   ret =3D id;
>=20
> A similar issue was flagged in fpga-bridge.
>=20
> So remove the unused stores.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/fpga/fpga-bridge.c | 6 ++----
>  drivers/fpga/fpga-mgr.c    | 4 +---
>  2 files changed, 3 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
> index 4bab9028940a..2deccacc3aa7 100644
> --- a/drivers/fpga/fpga-bridge.c
> +++ b/drivers/fpga/fpga-bridge.c
> @@ -328,7 +328,7 @@ struct fpga_bridge *fpga_bridge_create(struct device
> *dev, const char *name,
>  				       void *priv)
>  {
>  	struct fpga_bridge *bridge;
> -	int id, ret =3D 0;
> +	int id, ret;
>=20
>  	if (!name || !strlen(name)) {
>  		dev_err(dev, "Attempt to register with no name!\n");
> @@ -340,10 +340,8 @@ struct fpga_bridge *fpga_bridge_create(struct
> device *dev, const char *name,
>  		return NULL;
>=20
>  	id =3D ida_simple_get(&fpga_bridge_ida, 0, 0, GFP_KERNEL);
> -	if (id < 0) {
> -		ret =3D id;
> +	if (id < 0)
>  		goto error_kfree;
> -	}
>=20
>  	mutex_init(&bridge->mutex);
>  	INIT_LIST_HEAD(&bridge->node);
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index e05104f5e40c..f38bab01432e 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -581,10 +581,8 @@ struct fpga_manager *fpga_mgr_create(struct
> device *dev, const char *name,
>  		return NULL;
>=20
>  	id =3D ida_simple_get(&fpga_mgr_ida, 0, 0, GFP_KERNEL);
> -	if (id < 0) {
> -		ret =3D id;
> +	if (id < 0)
>  		goto error_kfree;
> -	}
>=20
>  	mutex_init(&mgr->ref_mutex);
>=20
> --
> 2.26.0