Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4160996ybg; Mon, 8 Jun 2020 00:07:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwK/Mbfk87gOn19TNg+nb3S9Kl0seuJUy/lcaORrbVrGkEbvwAlEol2jQ1dHXSXaFqF572a X-Received: by 2002:a17:906:28da:: with SMTP id p26mr18832382ejd.551.1591600051449; Mon, 08 Jun 2020 00:07:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591600051; cv=none; d=google.com; s=arc-20160816; b=zSpO+4d5ZEPC6ezfBHirZOqw/yKdywn2oFe16Fi4hQ4U0gR6brKCOxSjxUnis43rXV QFW5Dn1Ura+0Jvle954saZmhiJ3n2OpnxGZqmkoao0Gjq8gCwUeTLX5legYHNTJZj9u5 RYXMox1d6FIJiL2yTndGaPeG1ESZBTeEPHN066xPXsOUtA18esFSS8fEfP7VWQI6VH68 cPViUnsMionYLdFo42CVxnpA5HhlADs52kPI0IPtLSSXn1Gw0+FPTgQ7W0a+wH+jLe+L JJpfd9thpbm/ZHblKA2I1pY96g2e8mYREAazkGhFMJfnTVF1vzgGMr/pfvj+ll/HAdnd R2Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=S378zGSpOf2f7Q1RRRkaUsWspkKGCnohH5tp/UAp9n0=; b=ZPgVSfiZmDe+cwpy69o3iJOs3MhiV7k8iCOabe0N8N4KFBGKetr2u1xZgNfmVcr/dQ oOoHYS3r93zBJVf8RHGeZN3OjxATDxG1KHMDWIzGbm4EpMOf6Eae9WIPuSBJHiHaDX3y AQnnva+1CAPDIINwTb3H8oJO8jKzeAn7M23PPFL6oBrY6wL2h5AFwH0NH0rdQiT8j8ET v6QwUr4fTfSwrFSELkDqrivP+WtkrCqOsT6tVXafH8RkE9t16Au1jIMtkkX+8jmwto13 Vcj+nVOwnRcnDxTbPbL6TQY3rFwDbn9DJmxT0xAO/X/HX+24I1Z+94L3BIVN/0fyJfNr pSHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="V56K/fI9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v6si7686787ejh.379.2020.06.08.00.07.08; Mon, 08 Jun 2020 00:07:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="V56K/fI9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728955AbgFHHFL (ORCPT + 99 others); Mon, 8 Jun 2020 03:05:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728053AbgFHHFL (ORCPT ); Mon, 8 Jun 2020 03:05:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CD07C08C5C3 for ; Mon, 8 Jun 2020 00:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=S378zGSpOf2f7Q1RRRkaUsWspkKGCnohH5tp/UAp9n0=; b=V56K/fI9pjhCqJKos2pXtAWzdJ IphlrsZzSU87eJoW4gUlDxlRMK8XKWdF6sWXg+ABe2d8azTKmXcwo3GsLbp9FC9nri4P7rNoQfK2b IHe4yDNGfXzdrzk45+HD73DnopkZDOcgi4mrLQY1pO7RZH5DUj/yPMTXKv+EvylhGDG27C1njPHqC z/ZJOu+NCVJl/u+gi+XqqeZYEVos53iiqpz2zEueMKYMSSLPowiJYMS6PYrgS5f467jzZLajCe5vk daoFPXBmmeck3KP+RwmUjtAP3gBckUQka4/SFJw6CYanCAUFcruaN0XJQlgaQTGlCkAeotzPRHQDa IsErvlQw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiBqF-0002Ke-SQ; Mon, 08 Jun 2020 07:05:07 +0000 Date: Mon, 8 Jun 2020 00:05:07 -0700 From: Christoph Hellwig To: Stefano Stabellini Cc: jgross@suse.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, tamas@tklengyel.com, roman@zededa.com, Stefano Stabellini Subject: Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus Message-ID: <20200608070507.GB15742@infradead.org> References: <20200603222247.11681-3-sstabellini@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200603222247.11681-3-sstabellini@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2020 at 03:22:39PM -0700, Stefano Stabellini wrote: > From: Stefano Stabellini > > The parameter is unused in this patch. > No functional changes. This looks weird. I'm pretty sure you are going to use it later, but why not just add the argument when it actually is used?