Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200604121142.2964437-0-mholenko@antmicro.com>
 <20200604121142.2964437-5-mholenko@antmicro.com> <418aa34e-af6c-3a3c-8d22-e7a122963b8f@infradead.org>
In-Reply-To: <418aa34e-af6c-3a3c-8d22-e7a122963b8f@infradead.org>
From:   Mateusz Holenko <mholenko@antmicro.com>
Date:   Mon, 8 Jun 2020 09:39:08 +0200
Message-ID: <CAPk366SL_MPV6Y4oYvkM=cPA9n36cWd3Km9ffeHYaZ9hpC9FqA@mail.gmail.com>
Subject: Re: [PATCH v7 5/5] drivers/tty/serial: add LiteUART driver
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        devicetree <devicetree@vger.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Stafford Horne <shorne@gmail.com>,
        Karol Gugala <kgugala@antmicro.com>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "Paul E. McKenney" <paulmck@linux.ibm.com>,
        Filip Kokosinski <fkokosinski@antmicro.com>,
        Pawel Czarnecki <pczarnecki@internships.antmicro.com>,
        Joel Stanley <joel@jms.id.au>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Maxime Ripard <mripard@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Sam Ravnborg <sam@ravnborg.org>,
        Icenowy Zheng <icenowy@aosc.io>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Gabriel L. Somlo" <gsomlo@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Randy,

On Thu, Jun 4, 2020 at 5:14 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi--
>
> On 6/4/20 3:14 AM, Mateusz Holenko wrote:
> > +config SERIAL_LITEUART
> > +     tristate "LiteUART serial port support"
> > +     depends on HAS_IOMEM
> > +     depends on OF || COMPILE_TEST
> > +     depends on LITEX_SOC_CONTROLLER
> > +     select SERIAL_CORE
> > +     help
> > +       This driver is for the FPGA-based LiteUART serial controller from LiteX
> > +       SoC builder.
> > +
> > +       Say 'Y' here if you wish to use the LiteUART serial controller.
> > +       Otherwise, say 'N'.
>
> That last paragraph seems to say that Y and N are the only choices here.
> It can also be set to M ...

You are correct, we'll update the help message to make it clear.

> --
> ~Randy
>

Thanks for your comment!

Best,
Mateusz

--
Mateusz Holenko
Antmicro Ltd | www.antmicro.com
Roosevelta 22, 60-829 Poznan, Poland