Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4180752ybg; Mon, 8 Jun 2020 00:49:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEGJ0/7W2ixZ4zL3Rrl2CW7LID5lwZdBcRVQKNNrQM6d5LUWlGOekJv8EEbdJ9Q8ofk52r X-Received: by 2002:a17:906:3c0c:: with SMTP id h12mr12090184ejg.64.1591602549096; Mon, 08 Jun 2020 00:49:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591602549; cv=none; d=google.com; s=arc-20160816; b=hiqPTGir7/IBTTv8MIN492WQGVU+bE0zFgXS4J5SqF2z51ZeZVWJqhXOqA8Y/Uf4c8 HYOCZgadMPpjb1CjHcHXLrSOs62F4Zln0mMxcR2TMYZoKtm98LROUb1Gkn3eBt65H+J1 5Tl3ifI1tN4pcBAq0PznyDzcghhegapync/HcH78IlT9UuJdXdEQKAwfCfa8LUVWB3z4 isLEHUUAjTl6uC0b+hKj/lnq1gQUYwr7tUH2FzuDnA46YO0PENMnqfWBaPV6FODrkgtW E55ePZjmIpD0MGzpjsGGC8HOsDIGVCB8tt/G9ZHWRahyId0B9QDKOH4Mrzdyl5/lZCO8 oWdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ii1LpA7xPLv2wdGt5UuWPaO4p+SzGddtJEFd/ScE1mM=; b=CFH++jOEdXpM1kzAyBEdQAZmGCbCQiAw1AgnBVgpuxGnSdjnIqP0MQ62x02TwNH03K YoAvg0kdZe7DArcv1HRmTE962X2w4D/tnr49z19Q3K95rFYc9BGd7OYv8oJNK8ofbqp5 rPb0kPIer5Fq9An+IKTIyzW5Jx8wtF5yCfmhfNwdfPfEN/yupkjP0dJ5KICn/iDpxpwx GkQqMg+6XIOFYo05K1bj4jGmwWZrKB04A1d/uUoVmTA/ucKD3XTfyiuDdo4SvRCMtwqK 11+oT/MdjdWOODe8CSquVEhRHMC1i9tZMPZnaPeo7DsOhxUPAtd3xQzRauB/RIeoJ2Ad OHfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="TbcMdd/8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m11si8576852edl.424.2020.06.08.00.48.46; Mon, 08 Jun 2020 00:49:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="TbcMdd/8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729048AbgFHHqi (ORCPT + 99 others); Mon, 8 Jun 2020 03:46:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729047AbgFHHqf (ORCPT ); Mon, 8 Jun 2020 03:46:35 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81706C08C5C7 for ; Mon, 8 Jun 2020 00:46:34 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id l11so16267064wru.0 for ; Mon, 08 Jun 2020 00:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ii1LpA7xPLv2wdGt5UuWPaO4p+SzGddtJEFd/ScE1mM=; b=TbcMdd/8OOsDoTOIeYwoPHkpvrb7BLpJgvs3osnO9kgBDS52ZeSXUiVqA3cdbFfqgQ j+Keb/5fI6A4lol2GJ6ijyjT5cuYD1OchuUXj4zFjT5O9U0kOCVWpub3uGIR4ix8Y4he 9LTLgODzbNdftzIB37a00BFCiR2bFxcMbQA44dL/XUL5uFD2NS0l4to3bE/K1fctTx0j 2K3o8Z/L7yYzIVoHwF6wYOfG05xBe9ZVWwdsQ4gRjdL5lRFe8YSTkdhtduLscBq/eYKi 58Q8jTnzbtIIt5FtaVALNA++QK8rJRqW2Uvyj29SIiBZmzT/CCw00/+UGW8ZAC0BmEPE sHzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ii1LpA7xPLv2wdGt5UuWPaO4p+SzGddtJEFd/ScE1mM=; b=pvf1qEHUA/AfoGvsyv7A9CBd0QIlPMTPZ0gPaxaR7G7JzlIaV7edwdDRrgf3XF0M72 Oye4GHm+hJKtv27i4tbM7l9k4PLTeRUYWI/N3QorGrUro/EGor+4sdJkJgbeUrVFhqOD EJp54ivCahwDvhcGvHYUYAeVioJIIkb5c+TZTRwwfrlWkldicqECADWdGupyL4l4PKV2 0b35OsLQxekYEh6TxxUHyZcwVdSVL/2zQFbPVLP6JIJ4ehlM9io4M091WzmE5D427sq6 K+RxxiLN3e2jnVsUHZwt/RPBVI0Qja6HFcw3yodv1y4YjC19qA/+sqKnCRYtgeqUE432 zWTw== X-Gm-Message-State: AOAM533nRh/tbbVoyeQ4juT0JayXxYBjmfQmFqQ3ZmsUyxbIXawYu2yY 4xjCu/V3vWrlnSJW+d+cBJ9hXg== X-Received: by 2002:adf:a449:: with SMTP id e9mr21978811wra.294.1591602392643; Mon, 08 Jun 2020 00:46:32 -0700 (PDT) Received: from dell ([95.147.198.92]) by smtp.gmail.com with ESMTPSA id u3sm22618436wrw.89.2020.06.08.00.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 00:46:31 -0700 (PDT) Date: Mon, 8 Jun 2020 08:46:30 +0100 From: Lee Jones To: Michael Walle Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Andy Shevchenko Subject: Re: [PATCH v4 05/11] pwm: add support for sl28cpld PWM controller Message-ID: <20200608074630.GA3567@dell> References: <20200604211039.12689-1-michael@walle.cc> <20200604211039.12689-6-michael@walle.cc> <20200605084915.GE3714@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Jun 2020, Michael Walle wrote: > Am 2020-06-05 10:49, schrieb Lee Jones: > [..] > > > +static inline struct sl28cpld_pwm *to_sl28cpld_pwm(struct pwm_chip > > > *chip) > > > +{ > > > + return container_of(chip, struct sl28cpld_pwm, pwm_chip); > > > +} > > > > Why not save yourself the trouble and just: > > > > struct sl28cpld_pwm *pwm = dev_get_drvdata(chip->dev); > > Is there a reason why not a single pwm driver uses something like that? Copy/paste? Habit? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog