Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4205008ybg; Mon, 8 Jun 2020 01:38:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBd8X8ip33eTj115dVnV7FMKPMtLniITPzTXdYmBRlbzmaSFFvdYVMJWIqfqypYY8aXAD4 X-Received: by 2002:a17:906:799:: with SMTP id l25mr19602889ejc.234.1591605509342; Mon, 08 Jun 2020 01:38:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591605509; cv=none; d=google.com; s=arc-20160816; b=OkbZyetMYET7yW9qWZq8od5qzPLqaiCdx3OCpg+6aBEe3lj9jc6P2nvIIUnWhcIJjp FysuhMkU012E8FMFDRCIfSPIzgHkb0WMKdbY1cKVYvSAkGw9MliHpYMbC/1+l5/IdauK CeO+pPzA2V4IaojFVvptOOf21CUeOyz7FFyZLqGN74Yuwn/5unihr96/0lWXx4H8JQKK enzxcIbcYDFgcR48XMjJGvevupURVkIQXG/084YSnG/1if75OWWIuka1BWw5SeM3m57m e5p8OzmQRbQUAXi20s8nlylD56YM+kIihPsc0UujtzUgoTuUKOK14e4J20GVZOF7PX/1 D1Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=t9NVY6b8KvF2OcPjgdEshcvuFXF+/A7lSVDpGHnbaMA=; b=Nu+XOzoj3KPmEuF4zYNWiIv1zADm/EFpLpSBge1ADNSmHVMOXuuETTzWWcSH0xq3Of VbOCAJh4YwmG1G4xgKo0QH5z/BS24RPZqTMRHqjlCAf5NxLWpvcWYbWJQ4jFhCm114Vv PvuqWsDeS1wr/fpkTfkHvTtwG/UO2pvDmm1Ne+4bcg9vx5enajfpRx+oNUgKCyuUTV6M G8oJx1WHU/LdWk2Dl8h0mictE4UJiQZOmlALF86qQ9FdxMHSZVrcpHgfDLaDENkRLcQ1 0q2Wwt514f/OG3e2OBPGucgqccxZ0+TgrRgsY43FKDpj+yLwlvTmGUkzKcJqeqO++h67 4vlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h2si8229168ejq.305.2020.06.08.01.38.06; Mon, 08 Jun 2020 01:38:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729117AbgFHIfS (ORCPT + 99 others); Mon, 8 Jun 2020 04:35:18 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5867 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725927AbgFHIfS (ORCPT ); Mon, 8 Jun 2020 04:35:18 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id DF832CAECECAF2C25341; Mon, 8 Jun 2020 16:35:15 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 8 Jun 2020 16:35:12 +0800 Subject: Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: attach IO flags to the missing cases To: Jaegeuk Kim , , , References: <20200604235023.1954-1-jaegeuk@kernel.org> <20200604235023.1954-2-jaegeuk@kernel.org> <20200608025125.GA127000@google.com> From: Chao Yu Message-ID: <70f2b6f6-189f-bafe-6db8-7c16a4a7f6ac@huawei.com> Date: Mon, 8 Jun 2020 16:35:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200608025125.GA127000@google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jaegeuk, This patch should be applied before "f2fs: attach IO flags to the missing cases", otherwise, gcc may complain about implicit declaration of "__attach_io_flag". On 2020/6/8 10:51, Jaegeuk Kim wrote: > This patch adds another way to attach bio flags to node writes. > > Description: Give a way to attach REQ_META|FUA to node writes > given temperature-based bits. Now the bits indicate: > * REQ_META | REQ_FUA | > * 5 | 4 | 3 | 2 | 1 | 0 | > * Cold | Warm | Hot | Cold | Warm | Hot | > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,