Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DFB87C433CA
Subject: Re: [PATCH V2 3/3] mailbox: qcom: Add ipq6018 apcs compatible
To:     Jassi Brar <jassisinghbrar@gmail.com>
Cc:     agross@kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org,
        Devicetree List <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <1591441171-20341-1-git-send-email-sivaprak@codeaurora.org>
 <1591441171-20341-4-git-send-email-sivaprak@codeaurora.org>
 <CABb+yY2HhHSbP7UX_r1bGgpxzQKfC9aS8r9nxX5AOt8ENG5ACQ@mail.gmail.com>
From:   Sivaprakash Murugesan <sivaprak@codeaurora.org>
Message-ID: <0ee184f4-bc8d-09f5-d756-c87498e64777@codeaurora.org>
Date:   Mon, 8 Jun 2020 15:09:58 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <CABb+yY2HhHSbP7UX_r1bGgpxzQKfC9aS8r9nxX5AOt8ENG5ACQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jassi,

On 6/8/2020 2:15 AM, Jassi Brar wrote:
> On Sat, Jun 6, 2020 at 5:59 AM Sivaprakash Murugesan
> <sivaprak@codeaurora.org> wrote:
>> The Qualcomm ipq6018 has apcs block, add compatible for the same.
>> Also, the apcs provides a clock controller functionality similar
>> to msm8916 but the clock driver is different.
>>
>> Create a child platform device based on the apcs compatible for the
>> clock controller functionality.
>>
>> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>> ---
>> [V2]
>>   * created a new structur for driver data.
>>   * re-arranged compatible strings in sorted order
>>
> Please break this into two patches, first reorganise and then add new
> ipq6018 of_match.
have sent an updated patch series addressing the comments, thanks for 
your time.
>
> thanks.