Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4239185ybg; Mon, 8 Jun 2020 02:46:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7vXjAjZ4Wz+ws7/+9rLwGXTnHaoDe99a+dQLwd2pworVJZB3uPDTcQE5W96Ojl125+0pV X-Received: by 2002:a05:6402:1592:: with SMTP id c18mr22322243edv.40.1591609609832; Mon, 08 Jun 2020 02:46:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591609609; cv=none; d=google.com; s=arc-20160816; b=PbJJXbilEoO8fxuVlnIBhAOMVgkOWIZQ8jJ4V6o5x1M473AH21CCYWLO3CAzSJ6TY1 tTrdKCDw3SMO15kmZDO8f4rjUOAGjubbrBQM7kveioIBJgNiYFsXvyk4wkoW9P8YPELU CS1TosLKLhlmPtIenUUmWIE9M/3/DUVnG31lh7TaDbeA3ZkRfb8SNxkKTDKwVZb33ucB Tqm4L4qZ5gmgieDJ194+e3DEHoQOHW+IBnLKiFOLSMWCkwftKWI9JFdAEO5V9xfrN+C8 FpKzJRs6awztrW6vomYI7pvhenSUHvLm8kqxVnAuydNcZeSckc1nmry3DkU15rWzoNaZ xq5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=NXI0Z0J/4ooSNFN2GwSVlyNdAvGywcRXeFQ5674Mtzc=; b=CpzJgnsCbdB7caDA/1mO4Rdl1C1KOHpZrTVZIpZ+zPQbMKoRyD7uphxMW3Ye+GiJ3c nOQSX28n5yOyVU7/joSFxUW3Ix+mUsForqXJPhF/tOopns7RxZcRTW9QhGgwnjOQbUuu KjAoDlNlPiL/S4Ffqb3Dc3TQK5oBzVgo95/LxSfFEn1ReT65Mwf5D4VFM+GWB7aTNNj1 iCgoYfUzAuVHFjlIDzSsn0OzB4jLjqx+6ir+tJIBMaAfUwtMOIcfgWmrqLJJoC4p/FTN +5CsneppIPFSFG0axkJANHx0TB5MiI5JBntJq0YCAjZSQEyCIfdGttlw9adCnx70OnEX Ux4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r4puKIU7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id la9si8070762ejb.581.2020.06.08.02.46.26; Mon, 08 Jun 2020 02:46:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r4puKIU7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729220AbgFHJoW (ORCPT + 99 others); Mon, 8 Jun 2020 05:44:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729144AbgFHJoV (ORCPT ); Mon, 8 Jun 2020 05:44:21 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41F94C08C5C3; Mon, 8 Jun 2020 02:44:21 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l26so14651714wme.3; Mon, 08 Jun 2020 02:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NXI0Z0J/4ooSNFN2GwSVlyNdAvGywcRXeFQ5674Mtzc=; b=r4puKIU7t9t/z+Akeod8D0rhFdVAmL/DY1c4jq8ct0lJu6WcDcmDglH2T3nsaLueoh FYqSCosvbu7c0507caUgc8lPWCxfNOJBR1NNb+E9V2372WvWAqBrSfgKH0+uRFP59I6m OrY4syPydx3wueiiSOjsaeEfC8VD0l57zSAuCbHlyOpVnB5qrvDsl1rrS0yc3xht9Q98 eqqxs8zSHCyrU4X2e3+7YJKeCai2Ux6gFUS2KzsfjiPFzapXmPMBixsnWTXtKGSTMWwq 8NjaS5aZSDjHwq+j+4zWD/pj/BUNzIthnKixB0NCrgvuy7u2NoSrqk/UBmGnsZcWOV3W P4Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NXI0Z0J/4ooSNFN2GwSVlyNdAvGywcRXeFQ5674Mtzc=; b=BOuc6YuXwAAX4zEx0DPo3tmH5jGNt3/rNMMJzBqOWccFl8Hlm4KLidfQ/rcQoCNQV8 s6lwpz44PVqAd23mEcS9tocwccSeSE3ZnHOyLQ6CTPiD8Om3P902eJfDrRqGOeL0fEYn thhYOeYqW5yzyOrtmgKHxGgDDhJDeXMqW24SgiQMEdftMRy0hgl+Xxofttfv0zYpqxJL ZOSM9UsaChTOV7YfTNmPEQTvNhgTtB0DNTX0mqGZyeTIO5rs3Ti0zYEv8pSiJTH3zByJ PSjgIaLx1YDhKgY3JvJ2KUlrdhRui9fwvxJt8iYah4Wg22tE+LvLHxFzz7cymphGFhwk FxAw== X-Gm-Message-State: AOAM533Mu4nBgrHyW9GZ2um3twRshOX+eWYVEN9u44r9NJXtW/OieW6t e3iMp9YnkOg/wgzMnGvUU7k= X-Received: by 2002:a7b:cb11:: with SMTP id u17mr2312826wmj.84.1591609460016; Mon, 08 Jun 2020 02:44:20 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:181:90d0:6ce1:d6aa:6a23:353b]) by smtp.gmail.com with ESMTPSA id y37sm26415505wrd.55.2020.06.08.02.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 02:44:19 -0700 (PDT) From: Richard Genoud To: Dan Murphy , Sriram Dash , Wolfgang Grandegger , Marc Kleine-Budde , Faiz Abbas Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Genoud Subject: [PATCH] can: m_can_platform: fix m_can_runtime_suspend() Date: Mon, 8 Jun 2020 11:43:48 +0200 Message-Id: <20200608094348.12650-1-richard.genoud@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit f524f829b75a ("can: m_can: Create a m_can platform framework"), the can peripheral on STM32MP1 wasn't working anymore. The reason was a bad copy/paste maneuver that added a call to m_can_class_suspend() in m_can_runtime_suspend(). Tested on STM32MP157C-DK2 and emSBC-Argon Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Signed-off-by: Richard Genoud --- drivers/net/can/m_can/m_can_platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c index 38ea5e600fb8..e6d0cb9ee02f 100644 --- a/drivers/net/can/m_can/m_can_platform.c +++ b/drivers/net/can/m_can/m_can_platform.c @@ -144,8 +144,6 @@ static int __maybe_unused m_can_runtime_suspend(struct device *dev) struct net_device *ndev = dev_get_drvdata(dev); struct m_can_classdev *mcan_class = netdev_priv(ndev); - m_can_class_suspend(dev); - clk_disable_unprepare(mcan_class->cclk); clk_disable_unprepare(mcan_class->hclk);