Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4240053ybg; Mon, 8 Jun 2020 02:48:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5nFCTTXJZSbf6L4l07sfFjDkG2zjLR94wz1p+QJ70jQIEBlam3Ibo35JyWC05d2ilZrr0 X-Received: by 2002:a17:906:6410:: with SMTP id d16mr20998756ejm.376.1591609710524; Mon, 08 Jun 2020 02:48:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591609710; cv=none; d=google.com; s=arc-20160816; b=icfu0dVRfgF0PrKZZ7o/+u+WirvZxh8rmhNXqH+MkPRegXWyvGxYvyDR6HXqYKfVlZ 0edmHqoGva6sgxM2pGNhnTbcOJB2pnL2r4dOwy9kvem2Fht3bYlDSJgjBf+20qcupCv6 bhR0sS5wKL85VSdzbH1m2SwFvJHUFRq7dpI/mZ5OKTUeO08RvW8xRsVKJ40k8auEpHG0 /aTV/A00aTbNM1+TZ/xYW4FfF+ggleAkii7d0a9KmK85vUCmYbp3Ipw72NqjSD1a/m0q vxgI8XSK/vUyujNyeQ76QMoVrHz2ReEG1xYJP1VnI3SFL9UfUfszG3khRuJlh9ReeI65 md4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=kol/mTHTVhoGIwKuk6EIdanpIihMAd/NI3dQP6aMTfw=; b=nk6gOLFxWW7Z0GPtZBSbqgj6Jx+5UOAo1k8B6ytDVKlnkx3n5mmaDCyTLcRHGfW6Ra S3Xjp5JZEZ8ss7Vx6y/WUSySo57nFNUPYZKzPJ2cDqqXMiilYUuAbILU1BKTwS+FvTb5 QlPFKMvkY29dusJsn3xQwHwnVOFO1k+HHW/B0kLTzwH1dJW+Fx0gT4BPCB/boa5GuJeT Gbhoj+okSA791OdrrAvSh9qZ9N68jyXqbmXbFiW2XJ/vpiVQF9w9KWjrjsuW9fjqEIzE 50nT77K7mIgE2X2a0lCgJLPtCkznITnSLeeFxyRo2TQGBJZJwEE5bolNFeTrVxbbj3vs ISTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JK20nP9L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s20si8313798edw.254.2020.06.08.02.48.07; Mon, 08 Jun 2020 02:48:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JK20nP9L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729259AbgFHJpk (ORCPT + 99 others); Mon, 8 Jun 2020 05:45:40 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:46277 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729223AbgFHJpj (ORCPT ); Mon, 8 Jun 2020 05:45:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591609538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kol/mTHTVhoGIwKuk6EIdanpIihMAd/NI3dQP6aMTfw=; b=JK20nP9LVdqx6nPmQRTCMiX97aUjQbwJKGkCwW0l2ricxfYieigpNtiU8l22q33Ha0Lnwj oeekL9ZO/M+g/G2n3bfKIXJVpAlUWZewXIev8oEgwXPaCcxW3KSFCL7b9eNX9KXu9EkC3N BQvRf7abyO9YMo6/nzKYz3Lsb4K46IA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-puXTpdvpNs61-enKuYXj1Q-1; Mon, 08 Jun 2020 05:45:36 -0400 X-MC-Unique: puXTpdvpNs61-enKuYXj1Q-1 Received: by mail-wr1-f70.google.com with SMTP id e1so6949150wrm.3 for ; Mon, 08 Jun 2020 02:45:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kol/mTHTVhoGIwKuk6EIdanpIihMAd/NI3dQP6aMTfw=; b=e1kTfVY2Kq8o5LeF439zqf5hXr/386V2nxukbz/AtecsQ64eK0j8MDbEbehvCHOK3j p4N6d9Rh9Tc3xmZEmWwmMv7nrckK2c3daEIAH6GIHbJoXsXkOHHUgF/Y/Ql48QOl5nJO KItCn9lhxAizLaZZUdrStq5Aap3AnSkxTd2368Q4e9jwtbttTr9n+X7KFbohHXDxi9iY WEy2YIT7sADQJr6yoiJIKtXG1amg3Il/FEfl5clGO0qTGxhzSvDzWWqTkurmFPSiKLUv jPaauXGbWx8e+MoiH5rE8mW0fiN4GFYPWYwViLMTIXZHQhf1m3YDE2fHEJ+8k1sumPUa BodQ== X-Gm-Message-State: AOAM530cb+tlKOEL3wBhl+/5RMkeM5QDvQHojwnIHoXE3AfI+DDrVIhI 3x8MIP0DjCegldqrVp9JUzFmDy6nmQJMrL5r9t9c74SahS2YoWYEqx97pF4y2kvWdRea2I7fYsJ lEjh6PKWGbU3QnNcCfATz69oI X-Received: by 2002:a1c:6606:: with SMTP id a6mr14991273wmc.37.1591609535377; Mon, 08 Jun 2020 02:45:35 -0700 (PDT) X-Received: by 2002:a1c:6606:: with SMTP id a6mr14991247wmc.37.1591609535163; Mon, 08 Jun 2020 02:45:35 -0700 (PDT) Received: from redhat.com (bzq-109-64-41-91.red.bezeqint.net. [109.64.41.91]) by smtp.gmail.com with ESMTPSA id o10sm23169984wrj.37.2020.06.08.02.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 02:45:34 -0700 (PDT) Date: Mon, 8 Jun 2020 05:45:31 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rob.miller@broadcom.com, lingshan.zhu@intel.com, eperezma@redhat.com, lulu@redhat.com, shahafs@mellanox.com, hanand@xilinx.com, mhabets@solarflare.com, gdawar@xilinx.com, saugatm@xilinx.com, vmireyno@marvell.com, zhangweining@ruijie.com.cn, eli@mellanox.com Subject: Re: [PATCH 5/6] vdpa: introduce virtio pci driver Message-ID: <20200608054453-mutt-send-email-mst@kernel.org> References: <20200529080303.15449-6-jasowang@redhat.com> <20200602010332-mutt-send-email-mst@kernel.org> <5dbb0386-beeb-5bf4-d12e-fb5427486bb8@redhat.com> <6b1d1ef3-d65e-08c2-5b65-32969bb5ecbc@redhat.com> <20200607095012-mutt-send-email-mst@kernel.org> <9b1abd2b-232c-aa0f-d8bb-03e65fd47de2@redhat.com> <20200608021438-mutt-send-email-mst@kernel.org> <20200608052041-mutt-send-email-mst@kernel.org> <9d2571b6-0b95-53b3-6989-b4d801eeb623@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d2571b6-0b95-53b3-6989-b4d801eeb623@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2020 at 05:43:58PM +0800, Jason Wang wrote: > > > > > Looking at > > > pci_match_one_device() it checks both subvendor and subdevice there. > > > > > > Thanks > > > > But IIUC there is no guarantee that driver with a specific subvendor > > matches in presence of a generic one. > > So either IFC or virtio pci can win, whichever binds first. > > > I'm not sure I get there. But I try manually bind IFCVF to qemu's > virtio-net-pci, and it fails. > > Thanks Right but the reverse can happen: virtio-net can bind to IFCVF first. -- MST