Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: vfdto/nZ3izPumJWcYk4nZETNg1kIsEhJrqYmqraKP+Qq19DekS8p9TI+5FKuUbj2yC0y1ZvR0
 nDo5/w4tQdpQ==
IronPort-SDR: SdICpjyn66NeOygcbfWSz3T5d9SOAP20VjsGmwBQetIXAaZ8F1gmawuyioOc0u/U1RehKs9wNJ
 YPxqzBblVokg==
From:   "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@intel.com>
To:     "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
CC:     "kishon@ti.com" <kishon@ti.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "Hunter, Adrian" <adrian.hunter@intel.com>
Subject: RE: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support
Thread-Topic: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support
Thread-Index: AQHWPW0sjYAQ0wPt5kOikMPhhrn48KjOfn8AgAAFLdA=
Date:   Mon, 8 Jun 2020 10:37:25 +0000
Message-ID: <DM6PR11MB3721F0D18434843D1B074623DD850@DM6PR11MB3721.namprd11.prod.outlook.com>
References: <20200608081501.29558-1-wan.ahmad.zainie.wan.mohamad@intel.com>
 <20200608081501.29558-3-wan.ahmad.zainie.wan.mohamad@intel.com>
 <20200608100754.GD2428291@smile.fi.intel.com>
In-Reply-To: <20200608100754.GD2428291@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 250fd440-7eb5-4c85-a346-08d80b97ef82
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2020 10:37:25.8219
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: edN3Rb9wpDJMa+7Fav1TJImhBW9JMMNT+SsuE/3xla1gvHkxbA5108JZsx/6RuCsco8oPpZNF6AhYf+ICYXGH3NVYI7+LtLNlSe/KTRcKb1y078pxshnOzBnsXNFU/e9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3243
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Shevchenko, Andriy <andriy.shevchenko@intel.com>
> Sent: Monday, June 8, 2020 6:08 PM
> To: Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@intel.com>
> Cc: kishon@ti.com; vkoul@kernel.org; robh+dt@kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; Hunter, Adrian
> <adrian.hunter@intel.com>
> Subject: Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support
>=20
> On Mon, Jun 08, 2020 at 04:15:01PM +0800, Wan Ahmad Zainie wrote:
> > Add support for eMMC PHY on Intel Keem Bay SoC.
>=20
> I think I commented on something already.

I don't recall any. May be on other similar patches.
I will wait for few days before sending next revision, if it is okay with y=
ou.

>=20
> ...
>=20
> > +	if (ret) {
> > +		dev_err(&phy->dev, "dllrdy failed, ret=3D%d\n", ret);
>=20
> > +		return ret;
> > +	}
> > +
> > +	return 0;
>=20
> return ret;

I will change in next revision.

>=20
> ...
>=20
> > +	if (IS_ERR(priv->emmcclk)) {
> > +		dev_err(&phy->dev, "ERROR: getting emmcclk\n");
>=20
> > +		return PTR_ERR(priv->emmcclk);
> > +	}
> > +
> > +	return 0;
>=20
> return PTR_ERR_OR_ZERO(...);

To clarify, I should replace the block above with,
return PTR_ERR_OR_ZERO(priv->emmcclk);

>=20
> ...
>=20
> > +	priv->syscfg =3D devm_regmap_init_mmio(dev, base,
> > +					     &keembay_regmap_config);
>=20
> One line.

I will change in next revision.

>=20
> --
> With Best Regards,
> Andy Shevchenko
>=20