Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Subject: Re: [PATCH] soc: amlogic: meson-gx-socinfo: Fix S905X3 ID
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <7d58e4db-2893-3675-eb93-ea14c3534b5b@baylibre.com>
Date:   Mon, 8 Jun 2020 15:32:03 +0400
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kevin Hilman <khilman@baylibre.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <ACA41DA3-88A4-4141-AEAD-C056C9834B6B@gmail.com>
References: <20200604044808.30995-1-christianshewitt@gmail.com>
 <7d58e4db-2893-3675-eb93-ea14c3534b5b@baylibre.com>
To:     Neil Armstrong <narmstrong@baylibre.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 8 Jun 2020, at 12:58 pm, Neil Armstrong <narmstrong@baylibre.com> =
wrote:
>=20
>> The current value is taken from Amlogic's 4.9 bsp kernel which =
appears
>> to use the wrong ID. For comparison, here's before/after:
>>=20
>> [    0.152237] soc soc0: Amlogic Meson SM1 (Unknown) Revision 2b:c =
(10:2) Detected
>> [    0.152463] soc soc0: Amlogic Meson SM1 (S905X3) Revision 2b:c =
(10:2) Detected
>=20
> For SM1 we have weird values, here are the one we gen on KernelCI:
> SEI610 (S905D3):
> Amlogic Meson SM1 (Unknown) Revision 2b:c (50:2)
>=20
> VIM3L (S905D3)
> Amlogic Meson SM1 (Unknown) Revision 2b:c (4:2)
>=20
> And you report now:
> Odroid-C4 (S905X4)
> Amlogic Meson SM1 (Unknown) Revision 2b:c (10:2)
>=20
> And at the time you reported:
> VIM3L (S905D3)
> Amlogic Meson SM1 (S905D3) Revision 2b:c (b0:2)
>=20
> So I'm quite lost here=E2=80=A6.

In [1] you added the SM1 SoC ID and S905X3 ID { "S905X3", 0x2b, 0x5, 0xf =
}
which matches the BSP kernel source.

In [2] I added a second S905X3 ID { "S905X3", 0x2b, 0xb0, 0xf2 } for =
VIM3L, but
this was a mistake (the chip is S905D3) so [3] corrected it to { =
"S905D3", 0x2b,
0xb0, 0xf0 } which matches my VIM3L board. If the VIM3L=E2=80=99s in =
KernelCI now show
"2b:c (4:2)=E2=80=9D it looks there has been a package change (silicon =
fixes?) and we
need to add another S905D3 package ID.

In the last week I helped three different users install LE on S905X3 =
Android
box devices, all of which declare "2b:c (10:2)=E2=80=9D as the SoC ID, =
which matches
the only S905X3 device I own (Odroid C4). So I assumed the BSP is wrong =
and
sent this fix patch.

If SEI610 is S905X3 (implied by the original SM1 submission from you) =
KernelCI
output shows the current ID is wrong (=E2=80=98Unknown=E2=80=99) so we =
probably need to fix it
with { "S905X3", 0x2b, 0x50, 0xf0 } then add new S905D3 (VIM3L) and =
S905X3 (as
per this patch) IDs.

If SEI610 is S905D3 (as stated in this thread) the fix in this patch is =
still
correct, but we also need to send a second patch to add two new S905D3 =
package
IDs (SEI610 + VIM3L).

I=E2=80=99ll ping you off-list to discuss.

Christian

[1] c9cc9bec36d0 ("soc: amlogic: meson-gx-socinfo: Add SM1 and S905X3 =
ID=E2=80=9D)
[2] 1d7c541b8a5b ("soc: amlogic: meson-gx-socinfo: Add S905X3 ID for =
VIM3L=E2=80=9D)
[3] fdfc6997bd08 ("soc: amlogic: meson-gx-socinfo: Fix S905D3 ID for =
VIM3L=E2=80=9D)