Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4307837ybg; Mon, 8 Jun 2020 04:43:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuKivCqPk/eTir+3kix3Dx7llmG1AcqdAqxUzgjpo2YItDjseHZAnSo/ACllQ0k9HmrfCP X-Received: by 2002:a17:906:af62:: with SMTP id os2mr20293532ejb.345.1591616583087; Mon, 08 Jun 2020 04:43:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591616583; cv=none; d=google.com; s=arc-20160816; b=ltnO/ka9qX9wVqaTip6etRTWtdL4JGMMg3+fI9JEXJuhmVMyKQEC/NM451hvFpAtUG sMTv0hcXA7FqHm3rgb2y/A9nLmClTrE++rbFHYwMq0KxMhqlYM00Icm3aEYbetHkjS5s Oe6EF4l4UBKONW8eRm9kAFvW8u42etuGSYRWEWODyPDJjF979G+AcXJZ5nEBCnTZqI4/ gSe97n57TLXAm1AeWBgYPgXilCVBzl8eI5eIj2giVlmKZytvPu0qR9gzPXJx4wAVpSpf Phg+Jd6nSRdVf5Z8sBVOUEUrxNfRygxr+Bs6tSzbaLAoXLqmG/3tczZHbrNKP3zJEZBs 6PwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=x4taCFMl1JSd2Q5eNsTgPag9K1UCnAlZgI2Ug8F0LTc=; b=C5hqZW2ef6V2WJAgUf/ql3k+k+cbYkEU4m6cI1VtN2gg2iF5z83n0vsrJu5di5sM/J QynsoD2pof2q58bIQvOBUdp01vK+LS0oBGNDS0HdqSOj4aRkWlvzMH/96UjfXa/lY6Hb wq9KeTvo9jlDW11hUreP9h4ZNVJzjur+dfjLQjrLgYmWZHQbEf4SABe7SRqMVLE50fbr nURBWzyrnI41HReTqIRslzGA8ENsU0txdozWxFfE2i8fA4aVQSzQXzVQ7Vk5Tm3By89O DnZzuzC0HOKaB54FX/zipXs5z0omW0yxDKVEsWPIrV9HTZcRZpdCUjjRCBs036GJD8sv IxcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rIRuyu7H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx10si8708183ejb.74.2020.06.08.04.42.40; Mon, 08 Jun 2020 04:43:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rIRuyu7H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729593AbgFHLkx (ORCPT + 99 others); Mon, 8 Jun 2020 07:40:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:42036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729310AbgFHLkx (ORCPT ); Mon, 8 Jun 2020 07:40:53 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57A152074B; Mon, 8 Jun 2020 11:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591616452; bh=x4taCFMl1JSd2Q5eNsTgPag9K1UCnAlZgI2Ug8F0LTc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rIRuyu7HoF2N+aUEjIce4hAevgRqJwI+BsLOC3XtBOVLmgs9MWQKZAT5QGmDr5GKf fu7pg5IOce3RteJB6v7iXvzw0IRjCT8RWz4XrueqXh2wC5nzznCETcsHW8GeosgrBS MxsLKGoQ6TbwarH19XC95Pu9353pbL+po/cfNqx0= Date: Mon, 8 Jun 2020 12:40:50 +0100 From: Mark Brown To: Pavel Machek Cc: jbrunet@baylibre.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, khilman@baylibre.com, alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH] soc/meson: add missing free_irq() in error path Message-ID: <20200608114050.GD4593@sirena.org.uk> References: <20200606153103.GA17905@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g7w8+K/95kPelPD2" Content-Disposition: inline In-Reply-To: <20200606153103.GA17905@amd> X-Cookie: I'm rated PG-34!! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --g7w8+K/95kPelPD2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jun 06, 2020 at 05:31:03PM +0200, Pavel Machek wrote: > free_irq() is missing in case of error, fix that. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. --g7w8+K/95kPelPD2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7eI8EACgkQJNaLcl1U h9D2oAf+L+75A6sm74wpOyUZsv7DPH8rJApbMWamWaaL7Zq0ZrwKsFecGUq4jP37 FvyBa8xpKWuEbPQuvtG8XwFUMjy/VBn0FgKhjbetB7+sUrQg+erx4XzY81Nq5VcG Ov+61cWUPIKpY8Ysnj+xH1W+b5nY5EOsBfFvjNNsE3g1JadihgZrcAGdOBK3cy/7 aS/RStZcQedRmxpIIQvKhwr4j0Am1X8D2lPjFqs7hVl+g9I3t1bvKYdW/Y679FBz HgwoXfEOkrODZtQsuMLGAqYRbyGjYKzAesmp892xPWqM07MchsB5JaMl4I81bwkO WndnmsoTH4bOw+HPhgwcIRVT/FOqtQ== =yNKv -----END PGP SIGNATURE----- --g7w8+K/95kPelPD2--