Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4317509ybg; Mon, 8 Jun 2020 05:00:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3jhKw6OKg3lc5pS/hAYI8I5L5u98y57eLzvwx6zNMGQNPj4vqSsfyh/fcmYuSnXujkzO+ X-Received: by 2002:a17:906:6dcd:: with SMTP id j13mr17897923ejt.131.1591617633074; Mon, 08 Jun 2020 05:00:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591617633; cv=none; d=google.com; s=arc-20160816; b=fe1BMbfp08G8ZDdJsUGsq2TqSbAqZi0dD8jpNFWx438jDKcZwEJMrNl5/jPrabg1Ec 17evPjLrpq7aFsmVq14X2UKxI/NRLPDcbL102iCDd/dZO5muRkSFd08OjjPUP0pZh9MG eMxAvkfoHXPfAdXvMuUrc1B+wypBfFs/OYqWykjLX4XMa4yeypJFsOkK3HCrQnVMBLb4 TISnT4XqXTk3IeDMoHsQBJcd+70dZtGv9FTg2NxXtAC0dOrEJxvh5Edr0WvXYGGZky8n jsT1aNl5h0NBv7Vj5N5sUZ9REoSiwhGlJ0l7lWf52mL7qIBKRglykiekshrhrDNqB5O3 SJcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nAtsiXTcR+OAIznew/hWTw3IpqmB5O6uM3hw6iSU2Fo=; b=PgpKJS76QHOu6hC26v8DL5bEbthOPuDYJSMjdXaCBCA1+Xgu56SZGwegqGM+Qthz6U tyIQqIOvka8bgmxVYwbvqqdaF8ww6yG3DbrUEBjLSWJCf8cu8oRqwr0qi/Ph7ehEsVC8 Q6/hMfOMc5Wv/s8Y/k97+dpeqWgVdcq6moX/ENfpjZW079P6oXS0V0j8quz7/iuZP7D1 NgYcszQTFWi5JDpg5qZMxOiED0Tlnp0jvz7Nlnm7aooVMyei21HXoMNNoM4NcVwJOefC u/qJxeh+KFBVg1/H5Yi7beRKUD7NSYQ5Vo8tEwCrez1wxoeESsTTca4A00AFKnhmWQsi V7ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TsEbl3mi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si9203213edt.88.2020.06.08.05.00.09; Mon, 08 Jun 2020 05:00:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TsEbl3mi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729762AbgFHL5c (ORCPT + 99 others); Mon, 8 Jun 2020 07:57:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:47216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729549AbgFHL5b (ORCPT ); Mon, 8 Jun 2020 07:57:31 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E2632072F; Mon, 8 Jun 2020 11:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591617450; bh=nAtsiXTcR+OAIznew/hWTw3IpqmB5O6uM3hw6iSU2Fo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TsEbl3mitixyjIOjM1w4hUKYXomkdL5t+OU2sRkL262ye+9PR8XJjj0hkwTzmqgn+ Vr54CwuaIDyBn0Dpkgi88bsn/Wuo22C1848vdbbCcvzqaf4q4xDP/eAarZWeOnzyZ9 L8VOzwy/UDGDFapO3M6kRTPBLJDvOphztk1rlTZ0= Date: Mon, 8 Jun 2020 12:57:28 +0100 From: Mark Brown To: Pavel Machek Cc: jbrunet@baylibre.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, khilman@baylibre.com, alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH] soc/meson: add missing free_irq() in error path Message-ID: <20200608115728.GF4593@sirena.org.uk> References: <20200606153103.GA17905@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TeJTyD9hb8KJN2Jy" Content-Disposition: inline In-Reply-To: <20200606153103.GA17905@amd> X-Cookie: I'm rated PG-34!! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --TeJTyD9hb8KJN2Jy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 06, 2020 at 05:31:03PM +0200, Pavel Machek wrote: > free_irq() is missing in case of error, fix that. >=20 > Signed-off-by: Pavel Machek (CIP) >=20 > diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c In addition to the subject line issue your Signed-off-by does not match the From: in the e-mail and there's no From: in the body, please resubmit with these issues fixed. --TeJTyD9hb8KJN2Jy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7eJ6cACgkQJNaLcl1U h9D/cQf+L7dper1ZvO7kYwre40pI8oRGB48niTj/ZkjOhATMnrDe60Nd5z4m792w YoAXr9IELC+RF9XqtLINNvFb90CrXIkpG947Gmz7HRAG/6RHgomLQDhpx0nvu3b3 9CNRkiAx/cFTyI06laUaxVbUMVfqTZ1t6TQl5/Zj6ZBGqTkpRfF/D+z837DdhcAU DR3pZxR+d3K79tFmzhMbp1LoCCXnTYHW8jUMxZNe6X2sumd/WkinCAZZV/JyS+k1 WTwS8Zumd/FdDu6p2ukRbQmo9jPw1t/vBCUm3l2il9Rlm0NgqkPigCZi3xNWUEBc rdhd4zkQxoQqUzquhAnsdDcXwm3zwA== =TJnD -----END PGP SIGNATURE----- --TeJTyD9hb8KJN2Jy--