Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4348407ybg; Mon, 8 Jun 2020 05:46:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHZ3aWaIC0t51fdMGMOma5+mrpbnjebJ6hszvQb6yYMQ7m2J+1kIrYZ0KykfWrp3bmUmNo X-Received: by 2002:a50:ac84:: with SMTP id x4mr22593761edc.124.1591620415580; Mon, 08 Jun 2020 05:46:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591620415; cv=none; d=google.com; s=arc-20160816; b=bkVBz1KPvY79y3afmunsZFf1NtUQFShQr1vSX39dwTgAMsnTxJYoy2rATF/UWltxOO aylrwg4k1Cv1Lc1t3oCQB6JyRO9O5z7+lFf3PxZspge1cdaOC6l6qxbyOObbZdBqBory G8D2oUn6CqJtUufTsqmwnkopV/wRfWXn2VDmv387HIlkPOyuFf5DAYHem8pyKLMxiSXQ 5MgIU3N46aSQJfcb0c11cBNRquNaD92i+crHW2K9uFk4jgFN7qMoJOCvks7nHMCKk9Bo nuPnYgA9MalN0HdThtboNGux4a5kiizcDuNVRAzjb3nvSpVfIvbLK4Ph5Jg8xOQip634 LJ0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=KKvfPpe15lkurNZJEw0UfeqDk084iGdiB1bVboZ3ZnU=; b=fJqLwCxeDdUNth4SvcyXp8CIuCfqclwaqzj0qeFi3M6YXA86n/MsbCaG9we8CY7NJa i27qVpVGvJdQRbyXoFWTiMGBNb1VW8yAbTWukfONRrO6ZyxMJoTPVGZYAVcVMLjT6uUN 6SIT06cq4a5+7UHvUeHbYysAz5qwnc6mxd9dIqEJMPA98Py4L7AatNG1/msNA97B01sd T/n8IFvd0FiICQ6ioLOQP73PaTT90YECjG3x+mpTLcM6821WLjGJNyIkYCyC2RdZlsl9 9rVzhL0qbNU6NJ/M8A4XXNi/Cff28GgUlATCrqH7wUiDSWXbsExha0oOj+eVS1wEDWgd LoVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs24si8750485edb.4.2020.06.08.05.46.31; Mon, 08 Jun 2020 05:46:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729056AbgFHMoZ (ORCPT + 99 others); Mon, 8 Jun 2020 08:44:25 -0400 Received: from mga11.intel.com ([192.55.52.93]:46985 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728802AbgFHMoZ (ORCPT ); Mon, 8 Jun 2020 08:44:25 -0400 IronPort-SDR: lbm6liwUc1D8W6Z0wohrFf+rgw1bIGt5z5JqEbOiGw/SGFS73bsKNrkpHPE8zS0NMULIj1Wpzw xKA+we5jHdLQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2020 05:44:24 -0700 IronPort-SDR: Ir7ent4kIU9kKCtlp29Gx01dLQtEwFIftDR2b467Wm6HaWsl1f5LcG4ztgNgy42lKgtuKucnuz m/cX3hD6ejKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,487,1583222400"; d="scan'208";a="313867207" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by FMSMGA003.fm.intel.com with ESMTP; 08 Jun 2020 05:44:22 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jiH8b-00BgDF-Es; Mon, 08 Jun 2020 15:44:25 +0300 Date: Mon, 8 Jun 2020 15:44:25 +0300 From: "Shevchenko, Andriy" To: "Wan Mohamad, Wan Ahmad Zainie" Cc: "kishon@ti.com" , "vkoul@kernel.org" , "robh+dt@kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "Hunter, Adrian" Subject: Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support Message-ID: <20200608124425.GK2428291@smile.fi.intel.com> References: <20200608081501.29558-1-wan.ahmad.zainie.wan.mohamad@intel.com> <20200608081501.29558-3-wan.ahmad.zainie.wan.mohamad@intel.com> <20200608100754.GD2428291@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2020 at 01:37:25PM +0300, Wan Mohamad, Wan Ahmad Zainie wrote: > > -----Original Message----- > > From: Shevchenko, Andriy > > On Mon, Jun 08, 2020 at 04:15:01PM +0800, Wan Ahmad Zainie wrote: ... > > > +return PTR_ERR(priv->emmcclk); > > > +} > > > + > > > +return 0; > > > > return PTR_ERR_OR_ZERO(...); > > To clarify, I should replace the block above with, > return PTR_ERR_OR_ZERO(priv->emmcclk); I left the context. -- With Best Regards, Andy Shevchenko