Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] bpf_stats_record: Add null check after malloc
To:     gaurav singh <gaurav1086@gmail.com>, ast@kernel.org, kafai@fb.com,
        songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
        john.fastabend@gmail.com, kpsingh@chromium.org,
        davem@davemloft.net, kuba@kernel.org, awk@kernel.org
Cc:     netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <CAFAFadBRhEwuFCa-kMNPgRF8+gHycVvWcGfvbX0Pmjb6wt4SZA@mail.gmail.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <f26fa159-f850-5a21-14ab-a8b9cc48a125@iogearbox.net>
Date:   Mon, 8 Jun 2020 16:15:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <CAFAFadBRhEwuFCa-kMNPgRF8+gHycVvWcGfvbX0Pmjb6wt4SZA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 6/7/20 1:46 AM, gaurav singh wrote:
> Hi,
> 
> The memset call is made right after malloc call. To fix this, add the null
> check right after malloc and then do memset.
> 
> Please find the patch below.
> 
> Thanks and regards,
> Gaurav.

Hello Gaurav, your patch is whitespace damaged. Please try and resubmit with git-send-email.

>  From 8083a35f85c6047f0377883ed66ae147f85fd3a9 Mon Sep 17 00:00:00 2001
> From: Gaurav Singh <gaurav1086@gmail.com>
> Date: Sat, 6 Jun 2020 19:42:53 -0400
> Subject: [PATCH] bpf_stats_record: Add null check after malloc
> 
> Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
> ---
>   samples/bpf/xdp_rxq_info_user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/bpf/xdp_rxq_info_user.c
> b/samples/bpf/xdp_rxq_info_user.c
> index 4fe47502ebed..c44b9a844066 100644
> --- a/samples/bpf/xdp_rxq_info_user.c
> +++ b/samples/bpf/xdp_rxq_info_user.c
> @@ -233,11 +233,11 @@ static struct stats_record *alloc_stats_record(void)
>    int i;
> 
>    rec = malloc(sizeof(*rec));
> - memset(rec, 0, sizeof(*rec));
>    if (!rec) {
>    fprintf(stderr, "Mem alloc error\n");
>    exit(EXIT_FAIL_MEM);
>    }
> + memset(rec, 0, sizeof(*rec));
>    rec->rxq = alloc_record_per_rxq();
>    for (i = 0; i < nr_rxqs; i++)
>    rec->rxq[i].cpu = alloc_record_per_cpu();
>