Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4423178ybg; Mon, 8 Jun 2020 07:32:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm3McCWyYKhuwB1Z6g8ZBhsY+iFiOn7XxA6x3j9bSwtsL3W0cgheq/uZ8mAJPLVGeVPOtR X-Received: by 2002:a17:907:4240:: with SMTP id oi24mr20436138ejb.127.1591626764225; Mon, 08 Jun 2020 07:32:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591626764; cv=none; d=google.com; s=arc-20160816; b=jer03SukBfIUfpRnE5R7Fa9XkMzT0nPp/yRHUMfdFi4jpBqYEN51f2ZIjL/nArpLYo yKJbM6OZ1Dyw4VTp/NyVu5zhoyvDmmsSUwZHoelH0pyPlccStX/iQCa9mwFzlEkuxj3x JzBHmhNxtr4YamcH/6pBIBVJed18NpY910Q4/D9eqFOu5nHdCOhx8PZsb981+P778rpO TX0yNRmhyrekA4raWjynnwZ8KdGB2lrVgv5we3/CyXZRXm/26WwHyr9jqe2gp+1eEeww kDRib8fEWWejofblrsXYzCkvCwPsoOGvmpr4TMXHLpFV6lvpyBDHz9NrR7W1A9KCgE3H Mqng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=n+zne9QKzwemtxYh0/9VvDSOvejbuyJsP12nNN1zU1E=; b=t+JbA8sybiGXhGWvN3/UnpcuRcIknmUFRXbRDJWLtDQeHaUgMtiONxT/kI3MjdbcEe OHzRyiq3eDNRM3kyX4r5xV0OZt9cfsfhGm4JAL4wYMWMfDmhCCwUCpRRR+snEXJ3v9bl Y2aSkhN56AGj2BPFtWypc+LbooUW6DhKPlpx0rxlYhuBsOxLx/Neoxt9Bdgc8dhyio0C f+WEX4I4eHKrxI89M28jyAFjGgmUU59GMZArPd8DSdueFkwRfKMWUQq/OaPqtfzvUxrY GzYYQ5Ly6blQAOkAc7aHwPvSlUlNEcuOLFeXD3pCE5i4Vuz3CuTrViwWGK0tY3+lPqFl wL+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=QjUIRsYG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si10299936edn.383.2020.06.08.07.32.21; Mon, 08 Jun 2020 07:32:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=QjUIRsYG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730005AbgFHO2F (ORCPT + 99 others); Mon, 8 Jun 2020 10:28:05 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:47952 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbgFHO2F (ORCPT ); Mon, 8 Jun 2020 10:28:05 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 058ERrIT017802; Mon, 8 Jun 2020 09:27:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1591626473; bh=n+zne9QKzwemtxYh0/9VvDSOvejbuyJsP12nNN1zU1E=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=QjUIRsYGB8DUlHu8T9JuZT87fmocvHzbrJfiIv+e1lTh44XrjpmNVrVynJbZ4issO 1PTyabe3TuPTi6iaYpKvZkZ3jPA0M6cmz/D2ydX+MGi/5fDkhJVArfj4+l3oNyaw89 DMk3CUg4XSIuQKRrVqKjrEOhEvJXQ+4ZqwWNULcE= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 058ERr5s078294 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Jun 2020 09:27:53 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 8 Jun 2020 09:27:52 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 8 Jun 2020 09:27:52 -0500 Received: from [10.250.52.63] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 058ERqtI037595; Mon, 8 Jun 2020 09:27:52 -0500 Subject: Re: [PATCH] can: m_can_platform: fix m_can_runtime_suspend() To: Richard Genoud , Sriram Dash , Wolfgang Grandegger , Marc Kleine-Budde , Faiz Abbas CC: , References: <20200608094348.12650-1-richard.genoud@gmail.com> From: Dan Murphy Message-ID: Date: Mon, 8 Jun 2020 09:27:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200608094348.12650-1-richard.genoud@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Richard On 6/8/20 4:43 AM, Richard Genoud wrote: > Since commit f524f829b75a ("can: m_can: Create a m_can platform > framework"), the can peripheral on STM32MP1 wasn't working anymore. > > The reason was a bad copy/paste maneuver that added a call to > m_can_class_suspend() in m_can_runtime_suspend(). Are you sure it was a copy paste error? Probably don't want to have an unfounded cause unless you know for certain it was this. Dan