Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Jun 2020 16:25:56 +0200
From:   Heiko Carstens <heiko.carstens@de.ibm.com>
To:     Chen Zhou <chenzhou10@huawei.com>
Cc:     gor@linux.ibm.com, borntraeger@de.ibm.com,
        linux-s390@vger.kernel.or, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 0/3] s390: use scnprintf() in show() methods
Message-ID: <20200608142556.GA7478@osiris>
References: <20200509085608.41061-1-chenzhou10@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200509085608.41061-1-chenzhou10@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, May 09, 2020 at 04:56:05PM +0800, Chen Zhou wrote:
> snprintf() returns the number of bytes that would be written,
> which may be greater than the the actual length to be written.
> 	    
> show() methods should return the number of bytes printed into the
> buffer. This is the return value of scnprintf().
> 
> Chen Zhou (3):
>   s390/crypto: use scnprintf() instead of snprintf()
>   s390: use scnprintf() in sys_##_prefix##_##_name##_show
>   s390/protvirt: use scnprintf() instead of snprintf()
> 
>  arch/s390/crypto/prng.c | 14 +++++++-------
>  arch/s390/kernel/ipl.c  |  2 +-
>  arch/s390/kernel/uv.c   |  8 ++++----
>  3 files changed, 12 insertions(+), 12 deletions(-)

All applied, even though the buffer has a size of 4k in all cases.
So this doesn't fix anything; but it doesn't hurt as well.