Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4482013ybg; Mon, 8 Jun 2020 08:54:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyV1Foy3WL7rwL3r4zFHWgjpuDzXCmO2XFRgkGbdmS7Gc2x1iDj3neIm1qewSDl9H22uRjd X-Received: by 2002:a50:fe94:: with SMTP id d20mr21900528edt.254.1591631678617; Mon, 08 Jun 2020 08:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591631678; cv=none; d=google.com; s=arc-20160816; b=KZUrzm8sEO3FM1NnIiiBtXmjPSLgfioRDprI5HJ9JrSpZr21L1diu9NKVZp2jbKRap JS4vR4IJi4M7ZYa5e84RfZiiDhciU4Wth6q8j+gRrmZJmtQo4deUP4n1vdqvf42t4jVH apCsuJw9n5oouK7Qi0svxUuW6qmlcK5Eps/Q+U8GNViiwqOhu/zxKblX1Kl16e+ND7E7 C3F7zRdbZOxhysETrFJyp08mlaQhiV9EhoTJAkE2WzEqYjTj1wafqS03GVrpMAsnO5pr 2kstz4XF8H/s1S52oqUUhWpSytxJbZgze9PR9aaVw1pUUyHgY/Ud7snqTDxB20iFvCe5 f4yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=lb09cWOAemFWrXTFBWu5AF2ByTLTf6iK++5rNvKOF44=; b=SUFHgeaPFOt8r5PKBm51h5dVErHExxEpXYh8DAFTztLIrPt55dMgPnEYB20oXbXaWE kpB5kvaKfWUGRyHaDJ6nyKgBkCySwqRU9VupIc0BsX2W30vTGGC1qavydFSDqnanpknH b5lQc/OdkCgBZ3PsGLAmtY6T5sUh0WycZEDfnfna61RGH0mQ5sjbshHP9x5+I51lJcI/ t8TUFPAoabD3mZM/0Bl1JQocuvzmyrr4n5s5UpKrRY4Pp2aEL5Cek0XbtIPFEb+QRHrX EKG7JhpFtPcb0U9WfN1zKTKUFV6DoxOWxkAz4fQK5Rt4QXVFLDhtlTPsPW8u7GZoievk 5cUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qJZhlPmc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a6si9342004edu.275.2020.06.08.08.54.14; Mon, 08 Jun 2020 08:54:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qJZhlPmc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730321AbgFHPuH (ORCPT + 99 others); Mon, 8 Jun 2020 11:50:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730250AbgFHPuF (ORCPT ); Mon, 8 Jun 2020 11:50:05 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BF50C08C5C2; Mon, 8 Jun 2020 08:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lb09cWOAemFWrXTFBWu5AF2ByTLTf6iK++5rNvKOF44=; b=qJZhlPmcOXGTC7Qd1RA6AuDl6L zH6tY8idQUmY7FzCLwKGNwuiGVMSoO9Rp3S2/4SoI1KBJOXHZa/Irl3BF4gbFogCJ+H/GECJgcLhO NXFASgAFNdfJHY5vjYNMSs2zaSkKvmindPUMC5CwWUp5SrZ/s4RjGMLSLwCeD4k2WlCiDVepPQ9Mk qei3P9+Sm9U3Scc/I7JIii8L2H0OhWm941JQEIDfvnjoiANcDh0GpYxtaGHYAaJ34XDheeS4bl2wa MybrU9yzKwgy50FA0ON6yeMVuWM7OvH6QhRbYIuChJceMEHzD8DiGv+gqAaZH4Y/CU9hy0ZSKwt6N IoILBjOA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiK1V-0002aK-5E; Mon, 08 Jun 2020 15:49:17 +0000 Date: Mon, 8 Jun 2020 08:49:17 -0700 From: Christoph Hellwig To: David Hildenbrand Cc: SeongJae Park , akpm@linux-foundation.org, SeongJae Park , Jonathan.Cameron@huawei.com, aarcange@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendan.d.gregg@gmail.com, brendanhiggins@google.com, cai@lca.pw, colin.king@canonical.com, corbet@lwn.net, dwmw@amazon.com, foersleo@amazon.de, irogers@google.com, jolsa@redhat.com, kirill@shutemov.name, mark.rutland@arm.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, rdunlap@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, sblbir@amazon.com, shakeelb@google.com, shuah@kernel.org, sj38.park@gmail.com, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, yang.shi@linux.alibaba.com, ying.huang@intel.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v15 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules Message-ID: <20200608154917.GA8408@infradead.org> References: <20200608114047.26589-1-sjpark@amazon.com> <20200608114047.26589-2-sjpark@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2020 at 01:53:23PM +0200, David Hildenbrand wrote: > > @@ -131,6 +131,7 @@ struct page_ext *lookup_page_ext(const struct page *page) > > MAX_ORDER_NR_PAGES); > > return get_entry(base, index); > > } > > +EXPORT_SYMBOL_GPL(lookup_page_ext); > > > > static int __init alloc_node_page_ext(int nid) > > { > > > > I've been told to always smuggle new EXPORTs into the patch that > actually needs it (and cc relevant people on that patch instead). A separate patch for anything remotely controversial really helps it to stick out, so I think keeping it separate is a very good practice.