Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750861AbWCUUbk (ORCPT ); Tue, 21 Mar 2006 15:31:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751149AbWCUUbk (ORCPT ); Tue, 21 Mar 2006 15:31:40 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:20753 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1750861AbWCUUbk (ORCPT ); Tue, 21 Mar 2006 15:31:40 -0500 Date: Tue, 21 Mar 2006 20:31:25 +0000 From: Russell King To: Olivier Galibert , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, David Vrabel Subject: Re: [PATCH 04/23] driver core: platform_get_irq*(): return -ENXIO on error Message-ID: <20060321203124.GC20424@flint.arm.linux.org.uk> Mail-Followup-To: Olivier Galibert , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, David Vrabel References: <11428920373568-git-send-email-gregkh@suse.de> <11428920383013-git-send-email-gregkh@suse.de> <20060321001336.GB84147@dspnet.fr.eu.org> <20060321080709.GD21287@flint.arm.linux.org.uk> <20060321125049.GB83095@dspnet.fr.eu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060321125049.GB83095@dspnet.fr.eu.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 30 On Tue, Mar 21, 2006 at 01:50:49PM +0100, Olivier Galibert wrote: > On Tue, Mar 21, 2006 at 08:07:09AM +0000, Russell King wrote: > > On Tue, Mar 21, 2006 at 01:13:36AM +0100, Olivier Galibert wrote: > > > On Mon, Mar 20, 2006 at 02:00:38PM -0800, Greg Kroah-Hartman wrote: > > > > platform_get_irq*() cannot return 0 on error as 0 is a valid IRQ on some > > > > platforms, return -ENXIO instead. > > > > > > 0 is NO_IRQ, and can not be a valid IRQ number, ever. A > > > platform_get_irq*() returning 0 as a valid irq is buggy. > > > > > > Check http://lkml.org/lkml/2005/11/21/211 > > > > No. That's Linus' _opinion_, which is not applicable to systems without > > the obviously broken PCI or ISA busses. On such systems, IRQ0 has no > > special meaning what so ever. > > Do the drivers know? If you look at the following patch in the series, the users of this function have been updated. So the answer is "yes". -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/