Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   David Hildenbrand <david@redhat.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v15 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules
Date:   Mon, 8 Jun 2020 20:15:50 +0200
Message-Id: <320E495A-1A3E-423B-A3E7-088004771E45@redhat.com>
References: <20200608154917.GA8408@infradead.org>
Cc:     David Hildenbrand <david@redhat.com>,
        SeongJae Park <sjpark@amazon.com>, akpm@linux-foundation.org,
        SeongJae Park <sjpark@amazon.de>, jonathan.cameron@huawei.com,
        aarcange@redhat.com, acme@kernel.org,
        alexander.shishkin@linux.intel.com, amit@kernel.org,
        benh@kernel.crashing.org, brendan.d.gregg@gmail.com,
        brendanhiggins@google.com, cai@lca.pw, colin.king@canonical.com,
        corbet@lwn.net, dwmw@amazon.com, foersleo@amazon.de,
        irogers@google.com, jolsa@redhat.com, kirill@shutemov.name,
        mark.rutland@arm.com, mgorman@suse.de, minchan@kernel.org,
        mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org,
        rdunlap@infradead.org, riel@surriel.com, rientjes@google.com,
        rostedt@goodmis.org, sblbir@amazon.com, shakeelb@google.com,
        shuah@kernel.org, sj38.park@gmail.com, snu@amazon.de,
        vbabka@suse.cz, vdavydov.dev@gmail.com, yang.shi@linux.alibaba.com,
        ying.huang@intel.com, linux-damon@amazon.com, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <20200608154917.GA8408@infradead.org>
To:     Christoph Hellwig <hch@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Am 08.06.2020 um 18:11 schrieb Christoph Hellwig <hch@infradead.org>:
>=20
> =EF=BB=BFOn Mon, Jun 08, 2020 at 01:53:23PM +0200, David Hildenbrand wrote=
:
>>> @@ -131,6 +131,7 @@ struct page_ext *lookup_page_ext(const struct page *=
page)
>>>                    MAX_ORDER_NR_PAGES);
>>>    return get_entry(base, index);
>>> }
>>> +EXPORT_SYMBOL_GPL(lookup_page_ext);
>>>=20
>>> static int __init alloc_node_page_ext(int nid)
>>> {
>>>=20
>>=20
>> I've been told to always smuggle new EXPORTs into the patch that
>> actually needs it (and cc relevant people on that patch instead).
>=20
> A separate patch for anything remotely controversial really helps it
> to stick out, so I think keeping it separate is a very good practice.
>=20

That used to be my approach until Michal told me to do it differently. And t=
here is a good point for it: Reviewers actually understand in which context i=
t is used and if it is really required.

Having that said, I don=E2=80=98t have a strong opinion on this.=