Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4587505ybg; Mon, 8 Jun 2020 11:34:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNo8Ph2rz3u2T13Dpl9nAJI0lRiIILPILMr2Ub2IjXKulA4Kr0nAUT3vlz/ganzmnrDKfT X-Received: by 2002:a17:906:5c0a:: with SMTP id e10mr7662424ejq.389.1591641297569; Mon, 08 Jun 2020 11:34:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591641297; cv=none; d=google.com; s=arc-20160816; b=smyBY+sJd017rNAhhaFv6RmCLbpNPOyTks2cNSLnyOIWmaR4v/8NZtcdLIYBaMz+yC gy5XKeM9NX1sxRHcNvmKF8Ky75Rc8x0VDb//HyoBXc+bH3+Ka2fuzFPiwHMV5d+C0eVX IH9EDBZwS1AA8+frx3AbVBbJkzYsc8Z3LzC+/yZK2vG6N0l9XyhyiGkOQvnFZTw/p6xl 3/gYCU+2QFYlWdHrLxGkvW2JNoJvD28inpimW9lHO7+p5+hWepmpowU94Bfe0hwpaSwb nqwfPi7aYVtY/nCggxVakRb63ftoCqXerA+njb7NiPQFRYhf8JvXUju1W5iNV2BoEjMU RKvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:autocrypt :from:to:subject:cc:dkim-signature; bh=D1aPL7KxKxKeugRD7PP714MQW2MINT0XVhSf26gafWM=; b=qS3v8JBCFu8fcY/Bvh9y7FmyPxP5DOy1v22QWx+0LOAClnptsMi2srnEqm3OvLBIep KpQ3RPZToMnza9fYNBsV1eXKl25ZoGeq04PdNbR6pBuclRK/hUMmMt8WRi9DZmKd9SwR EN9D6qIx/9Qy31olHPaaJ33nn8kpxdM7ZH03jGt4uKkZYfsC4TGa7CVN9z6HWigPzn3u sSU2eDAU1olyJlwrl0goy47LWJN+iXHieOsPlsWjmOvN2MnwwqzjXUvcwN0f+AeCmaFL I96W56teoT4OXsS0QbgYRMgMmL66URQPD/gAVBsEpq9TA6CJ4fwfLe8Ft5wBV+uxcT55 P0tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=cuS5Uer4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd12si8903946ejb.59.2020.06.08.11.34.33; Mon, 08 Jun 2020 11:34:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=cuS5Uer4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbgFHScU (ORCPT + 99 others); Mon, 8 Jun 2020 14:32:20 -0400 Received: from mout.web.de ([212.227.17.11]:45125 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgFHScT (ORCPT ); Mon, 8 Jun 2020 14:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1591641129; bh=IBDqx493tt1wkXPpzA/7XTXyPaT674q56+B8I9R8/Mc=; h=X-UI-Sender-Class:Cc:Subject:To:From:Date; b=cuS5Uer4odfzpa9bmbQtXv5wZ0gEHR4K/J4HmJ+9DFSKTILGPpjWZ+lIIZze/kz19 iLratHInx5wnGFThue81BGIC5EL/fI+M6IJnyl8hh473wm/ZtF6jiO2q0vfRaxpki3 PIxN+clmW0rdLr8elQwezyqinTKMhxks8d0D8Tfc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.49.116.236]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LnSGg-1j0nod1O9O-00hdVB; Mon, 08 Jun 2020 20:32:09 +0200 Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] coccinelle: api: extend memdup_user rule with vmemdup_user() To: Denis Efremov , Coccinelle , Gilles Muller , Julia Lawall , Masahiro Yamada , Michal Marek , Nicolas Palix From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <6c9c6a4c-c305-ddab-8a1b-e4dc448d643f@web.de> Date: Mon, 8 Jun 2020 20:32:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:iLwj2vJ0brvPvZKas/bjtr4Ytr7QXduKpi1DO9Ef38xrMnv2qkl Oclt+grMGWcZC+wYpEqApO6uJ3a3gpavFR0PkZxMsPxgLR++MUrpz+484gwhwAtDN9W2Jhq 2Vb26ufFZ8y0KGXfFTe5baW4KQeTBoqBMiyX2p2VFtf2EV0oZLB4ymAzXLa++m1/8UIHiCK 0ukmNHy+Qao51iivo2A1Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:VwCSdTMk4/c=:9UKXcnQ3ZtQlFAIgWoIzPi fsCnHyP+zCJMvr68eP93e48dM//1a0qPSTE1q0KrUtM5vicxZVKJ8mlsMhXC33I6XOuZJNFTK feYUoWGc/dmQc0KtM7Pde/EzC1P2q9HfV/zUlB1fXdwhBkKRR02qxzEAWIcQf7DkgaM6/fzAf uxKyKraTQ4mYdVb4wvg6a3lgLqLX8Fi1WkfJz49xfVjfx4cEjKAqWWfEB04wRGemR7jABmKbh UxQN3PdRD42Tv78AhlLgPftA7gXotTyXLpJ1XBFZLjuuRAK+l8S8XbTEko776WZ4mrizwbzAe UtZxpNt2J+LrwlkFSmhmPunZZFlp45D/USUi9XDZ21LtTs2L54tpvdZ4+jMjpQ9bEi52J94G1 FQOwRZXhZEic0v3RpxHs9974Nw2lc8WQP/vRfuzvxB3kFhuu7ek45Yy06O4RDpRYUsciasGhZ CLkcZtduTcww+GvF6GgsUFfEymzmKOqmhwOP2HhBTb1SlYoLpaYeGQJKpB/i8aqpBlji0wDmh M6R8Whe8FffluD9cCM2eFULGhAq4l1N/PCzrlhoEOxk3ve4ePgOXVUA9q2zZ+G2VyEn9Qy5SS eDzdZM9bhpP8rGbFr0HStQAO3USrXvkFn3MDzZkEbRfxr47mqvgljtGnQYZJoG72ozD+04JB4 ZB0ShNssYhYTB7InvxVQZxeYCcI0l2ld72h0CZ7CQsFukGNG/W3gMMJGylfn5s7EiBDc87uJU KcuHu64+7JnzhOGTlF/t8PGHh7hL3DPuOVSb4/sdbbC/tKfDGPokjaKgygCRg5EATB9NNpkYI MANKB9jbQeOS45Ij6ZtYbu3c0alxhZM21Aw3jQF7LEe2tgJvAA6zkGvfNKketFL6+JxyFjzB3 oMRN33Hou0B+0BAysDsSeiPoKjVwIPCQ4s5IeuL2qGa8R9gBVcN+eTMfDqZ8evUcxlRYl3OZR 6Fh1T77dnc9XchVL67GJnPlOcpibTC1jXuU02UTASRD17jFrxTJmTfKa2BjR58Tn2rULOvksS 5AnvxKET3VsaVR7OkgBVyXn5a5MJNCj/niuZlLaqJhQQRSOmXaLWDvk87sWJEyIs1yLK/QS0e Y139L5G7BIhWs8ZzBFkoeeB4PvxgPTinRuDknVYaggp0ytMFDNBZvGdExMKTARJIhu5YDIGDc Vh+Lp3Zmfnlo7f2PGlcDr42cwgAhPXCDKX6Jw0MXOkxcFvx/Boh6HttsVHtkEwHJIOAgEKQsb MvBIkkk7t2/gCXfXk Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E2=80=A6 +++ b/scripts/coccinelle/api/memdup_user.cocci @@ -39,6 +39,28 @@ =E2=80=A6 =E2=80=A6 > +@depends on patch@ > +expression from,to,size; > +identifier l1,l2; > +@@ > + > +- to =3D \(kvmalloc\|kvzalloc\)(size,\(GFP_KERNEL\|GFP_USER\)); > ++ to =3D vmemdup_user(from,size); I suggest to combine the desired adjustment with the previous SmPL rule by using another disjunction. > +@rv depends on !patch@ > +expression from,to,size; > +position p; > +statement S1,S2; > +@@ > + > +* to =3D \(kvmalloc@p\|kvzalloc@p\)(size,\(GFP_KERNEL\|GFP_USER\)); > + if (to=3D=3DNULL || ...) S1 > + if (copy_from_user(to, from, size) !=3D 0) > + S2 How does the SmPL asterisk functionality fit to the operation modes =E2=80=9Corg=E2=80=9D and =E2=80=9Creport=E2=80=9D? Regards, Markus