Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Jun 2020 11:49:24 -0700
From:   Matt Helsley <mhelsley@vmware.com>
To:     Julien Thierry <jthierry@redhat.com>
CC:     <linux-kernel@vger.kernel.org>, <jpoimboe@redhat.com>,
        <peterz@infradead.org>, <mbenes@suse.cz>
Subject: Re: [PATCH v2 1/4] objtool: Move object file loading out of check
Message-ID: <20200608184924.GA1284251@rlwimi.vmware.com>
Mail-Followup-To: Matt Helsley <mhelsley@vmware.com>,
        Julien Thierry <jthierry@redhat.com>, linux-kernel@vger.kernel.org,
        jpoimboe@redhat.com, peterz@infradead.org, mbenes@suse.cz
References: <20200608071203.4055-1-jthierry@redhat.com>
 <20200608071203.4055-2-jthierry@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20200608071203.4055-2-jthierry@redhat.com>
Received-SPF: None (EX13-EDG-OU-001.vmware.com: mhelsley@vmware.com does not
 designate permitted sender hosts)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 08, 2020 at 08:12:00AM +0100, Julien Thierry wrote:
> Structure objtool_file can be used by different subcommands. In fact
> it already is, by check and orc.
> 
> Provide a function that allows to initialize objtool_file, that builtin
> can call, without relying on check to do the correct setup for them and
> explicitly hand the objtool_file to them.
> 
> Signed-off-by: Julien Thierry <jthierry@redhat.com>

Reviewed-by: Matt Helsley <mhelsley@vmware.com>

> ---
>  tools/objtool/builtin-check.c |  7 ++++++-
>  tools/objtool/builtin-orc.c   |  8 +++++++-
>  tools/objtool/check.c         | 37 +++++++++++------------------------
>  tools/objtool/objtool.c       | 29 +++++++++++++++++++++++++++
>  tools/objtool/objtool.h       |  4 +++-
>  tools/objtool/weak.c          |  4 +---
>  6 files changed, 57 insertions(+), 32 deletions(-)