Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4623390ybg; Mon, 8 Jun 2020 12:33:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzz/pXQOS2hNpQs4MsGOfFsnXZTc4SLa1WqB8JyVNmBXBPnozT3r5n0RVcOLto4zPQhlYP0 X-Received: by 2002:a50:f611:: with SMTP id c17mr22615827edn.60.1591644784083; Mon, 08 Jun 2020 12:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591644784; cv=none; d=google.com; s=arc-20160816; b=JAFEAiPNhgQZ40E3Af54YO7cYqJKFavcT9kpSY+ngjZJZnWcarc7Ixfia69/AFmOTX Pm3QZtopodSmp7oV27SDsTa3r7H4E5eUdyo61CoxWWRaV+2unlJvqPmM7nl2EVsqgUwG cuiLJ71tL9c7LkeAQWkLGxgeJVCTZzXHp8yW4y9GZkxuTw5n2MiyNQBClzFiOPUpGzY/ 2/WeZdouNILk8c88ihacLZMBWf7aQWrL9+g9zSJzmqJM+21eV6qbKT8KyXavloWn47po XQ2oVEPUgkH+T4E47gdNcZPeqAecfjpFHOm9nBdqOiWZOkFKNUpclN0CXozLTUWa91TN NzKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=0sALcyIxJSnN9+c+WtRbO4KtGtcxXsp/c2OGd5SgOaM=; b=DZ+pNa+Oq4updAHhIa80f6K2Ek8oX+vpZ6VUDKHvVNLm1OE1xDkH2xP16EurS0f58o QZ26LKBwtr1eicBoTN45v5aqB86vNo0RLB8cIV7dQ8bPMG0C03RxcW4hXcIBO7Shrto7 pvWcKZ9iO+vP/NnpyaW+RJSsjwISrc2SILsWtXLA8Dz09/ryTu3ByTsfLjSLTDr8hbLc JIamwNILHrlmpjVhBNGgFx1J5Mn7SVpRvAYBN8+YIBzRsyZEfHn/9FJCQn89VmrNqPad TZYjEU9LA0GmyirZWD6TTwpggWF67zEWsryRRVLXsRPzrwicXcseNhjnGHqFJ1toQZUR FFLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=zvg3KOzs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h63si7290727edd.180.2020.06.08.12.32.33; Mon, 08 Jun 2020 12:33:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=zvg3KOzs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbgFHTag (ORCPT + 99 others); Mon, 8 Jun 2020 15:30:36 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:32908 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbgFHTaf (ORCPT ); Mon, 8 Jun 2020 15:30:35 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 058JMqx1159496; Mon, 8 Jun 2020 19:30:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=0sALcyIxJSnN9+c+WtRbO4KtGtcxXsp/c2OGd5SgOaM=; b=zvg3KOzs15PB4FwfOitluImkirmlmR4qwiSt3u5BZI3DauJOftsBInJq81e3pa5fF84N JcAM/0ve364zESBc6/+kBsjksLQwTfDPfDC1D+rX/8trd10HgHFqIcQ+zp+QvV8Mg+jc hQk+dOnLL+AttdgqwWmzPmKaXZC6TcRW4rpW3yFhfTW0EEfl3y92y6CcmRQM9+JxJCPg 0rAXmzH0ciJ4iCBDhTxE8FPqAvVYHzbl1FSmtpFJrmetkew26oFNtLIuyNxHy1HvVfDR Umx+VgcWYZRnzgUtJFDo6EaLTZ96a/CuLuzThoLJYPJzju3sf4kJ0V42OInno/CLl1B9 7Q== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 31g33m0n50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 08 Jun 2020 19:30:19 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 058JOLDp147960; Mon, 8 Jun 2020 19:30:19 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 31gmwqbw2c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jun 2020 19:30:19 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 058JUEL9020772; Mon, 8 Jun 2020 19:30:15 GMT Received: from [10.39.231.199] (/10.39.231.199) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Jun 2020 12:30:14 -0700 Subject: Re: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for xen_start_kernel() To: Benjamin Thiel , Borislav Petkov , Juergen Gross Cc: x86 ML , LKML References: <20200606142721.19486-1-b.thiel@posteo.de> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <21d6821e-e488-138e-a0be-2177c4aa13b2@oracle.com> Date: Mon, 8 Jun 2020 15:30:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200606142721.19486-1-b.thiel@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9646 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006080136 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9646 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0 cotscore=-2147483648 malwarescore=0 phishscore=0 mlxscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006080136 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/6/20 10:27 AM, Benjamin Thiel wrote: > Fix: > > arch/x86/xen/enlighten_pv.c:1212:34: > warning: no previous prototype for =E2=80=98xen_start_kernel=E2=80=99= [-Wmissing-prototypes] > asmlinkage __visible void __init xen_start_kernel(void) > > Add a prototype for xen_start_kernel() in a separate xen-specific heade= r. TBH I am not sure it's worth a new header file for a routine that is only called from assembly (and never returns). I'd just add the prototype right above function definition, with a comment describing why. I see a few examples of this in the tree. Or maybe we even have an attribute for this case? (I also suspect the same may be needed for xen_prepare_pvh() BTW). -boris