Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4641207ybg; Mon, 8 Jun 2020 13:04:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxW/AzcRflNhxTx4rLVnSb0ubHlmDdLAVHFUSgxlOgY6pWK05/rIKtlk700KHZ1QBL/nUR X-Received: by 2002:aa7:d9d6:: with SMTP id v22mr24495338eds.66.1591646680071; Mon, 08 Jun 2020 13:04:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591646680; cv=none; d=google.com; s=arc-20160816; b=VfGXV+oYQOaku9OmekBZJSnt8xb7bt508qtXlJccvf01OPf2bFkbIF/DUnVPfrUgb9 zIBj1CxmMuRP12CJ0tHOLOEkGpO4jqO9F8oftWTWxLe3RrYoFJ4s/wZPRTZEAZX18kKR txXesuB2TVk6kOcZklkR1AjCXZHBb+/Ry+xaOc2kTU003H3VRUlZoe4/nu6AKvYxLODV AUO+lHeVI/uMtEv41qMburijE3ZR67D00LD68IIo0e4uv3pmb7bfMk9mvixS76Pv9Jo0 mTwxjKV6irQmM2H5BR+VpzaBwTYdsoNO5O1dQFINDsRZu2PJPELCDWQcPmaS1hcdalCw u22w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=oOAfGaCLyEUmL6SML8rpJlmgZSVIZCkEfuNXlz3UUno=; b=DnRgEDaPaCMGlaCFMM9086lrQMwJHx6NJ6vaqb742SPOF0FLRn+3Qa1hOAIW5jtgu0 jT6lgx1kgrxjb/KOxD7NDAGJzGsDXlbrhzGzbGb1Nr6z948VAbADPiGWG1dME8H5Cg3Z Asss103zYO6LDBvkoYM/CeIOBaqofq4RTp9kx/XMkuYpeE82yPT0YgsTbkEFLTvwOXlD OM5fv1bxe1M956HR+cjgNIe7qDV51IBfn0qCi/gqIKyDwaLgghZEYQSK4Bl0Aqxj/p8G SmqudbCXBFDxM/EGYoZJUdDCD+t1iiFvzLAHguJiID0R/ZqQvKKdhU6sW+dQehpwmPLe I/uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=f7Ee9XLZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b5si4501005edz.386.2020.06.08.13.04.16; Mon, 08 Jun 2020 13:04:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=f7Ee9XLZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbgFHUAN (ORCPT + 99 others); Mon, 8 Jun 2020 16:00:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726431AbgFHUAM (ORCPT ); Mon, 8 Jun 2020 16:00:12 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C64C9C08C5C3 for ; Mon, 8 Jun 2020 13:00:12 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id x22so9017013pfn.3 for ; Mon, 08 Jun 2020 13:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oOAfGaCLyEUmL6SML8rpJlmgZSVIZCkEfuNXlz3UUno=; b=f7Ee9XLZ/qoZncV84bKI+UlSMiA38ED5NpPzvnN/+cYHOas1fDpre0f9sncyvxVCkY YACG1gQ9hr6+aZYWwiQDRgkxzqpU6CPbTjnWXzdw4gSH84vVzB26LnbFzzBiUw7ppthP uvqq/+ixcFLYX/lhoJH+mlMrMY6fYycyB9DwWVA20a5Kwy9WOXCGdyzkD7eH548c/oTd qfyeb2eVASZ5IkbIeVzpCvd3L0kw0tc0wHdnfU5+ufhZ1XfoF1VJvwT69PcgkdUBu9Nc TS+6OerPHLNHfL/OwdJbCgexeHB1DnY72mO6Zt9a2KpIe/GtSn1uVfmb0nTcH3aM0tOz OcFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oOAfGaCLyEUmL6SML8rpJlmgZSVIZCkEfuNXlz3UUno=; b=Nk/pfZ9BsqLbiB4gwYbq4aYKK+Y9Ep5Hqvkzi1dGn+9+QHkH4DIVMJx4iOagoETCFe LYc963QoVqDIRLPMnGB8KQ6io+VVpMFpyCIONmUCSukRoTDBZzmxBOVEUcGSAHZAG9d7 cnQnZ41mVS3F7C/QQRGNEZSHJB8wPsZtmCASa5ri6F3h1Ea7AL0nGenEfFHNcRRDCkmn 8v0/es0VblJpEkLUWh0u3NXQNoDYBEFIcmo2MGphind7hCHput3FyeWdzg3avhrFz7gr 5wDW5HFx7BzzkvcmSubzJo2HnME4HDL6wY95Gqziv1giEwNMMWo3lCeucOFzRRc1AhLT +WlQ== X-Gm-Message-State: AOAM5308cUGpYWXVXz/bE3iaYaiyfMOeImGvG2aO4Jv0Fl8tSQnIqnuT omB5kz3YLZW5xZsshybAg+wLLQ== X-Received: by 2002:a63:c407:: with SMTP id h7mr21097365pgd.174.1591646412020; Mon, 08 Jun 2020 13:00:12 -0700 (PDT) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id x1sm7675474pfn.76.2020.06.08.13.00.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2020 13:00:11 -0700 (PDT) Subject: Re: [PATCH 0/4] remove work.func To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Cc: xiaoguang.wang@linux.alibaba.com References: From: Jens Axboe Message-ID: <8092bb08-a6ef-a1b1-31e9-5a545304460b@kernel.dk> Date: Mon, 8 Jun 2020 14:00:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/8/20 12:08 PM, Pavel Begunkov wrote: > As discussed, removing ->func from io_wq_work and moving > it into io-wq. > > Pavel Begunkov (4): > io_uring: don't derive close state from ->func > io_uring: remove custom ->func handlers > io_uring: don't arm a timeout through work.func > io_wq: add per-wq work handler instead of per work Thanks, this looks good and also nicely enable us to build on it to eliminate that extra overhead. I have applied it for 5.8. -- Jens Axboe