Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Subject: Re: [PATCH v2] x86/umip: Add emulation/spoofing for SLDT and STR
 instructions
From:   Brendan Shanks <bshanks@codeweavers.com>
In-Reply-To: <20200608215315.GB23567@ranerica-svr.sc.intel.com>
Date:   Mon, 8 Jun 2020 15:36:18 -0700
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Andreas Rammhold <andi@notmuch.email>,
        "Moger, Babu" <Babu.Moger@amd.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5256D924-9BFE-47EF-9A3A-2B5FB7B79946@codeweavers.com>
References: <20200608181454.14210-1-bshanks@codeweavers.com>
 <20200608215315.GB23567@ranerica-svr.sc.intel.com>
To:     Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jun 8, 2020, at 2:53 PM, Ricardo Neri =
<ricardo.neri-calderon@linux.intel.com> wrote:
>=20
> On Mon, Jun 08, 2020 at 11:14:54AM -0700, Brendan Shanks wrote:
>> Add emulation/spoofing of SLDT and STR for both 32- and 64-bit
>> processes.
>>=20
>> Wine users have found a small number of Windows apps using SLDT that
>> were crashing when run on UMIP-enabled systems.
>>=20
>> Reported-by: Andreas Rammhold <andi@notmuch.email>
>> Originally-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
>> Signed-off-by: Brendan Shanks <bshanks@codeweavers.com>
>> ---
>>=20
>> v2: Return (GDT_ENTRY_LDT * 8) for SLDT when an LDT is set.
>>=20
>> arch/x86/kernel/umip.c | 34 +++++++++++++++++++++++++---------
>> 1 file changed, 25 insertions(+), 9 deletions(-)
>>=20
>> diff --git a/arch/x86/kernel/umip.c b/arch/x86/kernel/umip.c
>> index 8d5cbe1bbb3b..a85f0b0ec2b9 100644
>> --- a/arch/x86/kernel/umip.c
>> +++ b/arch/x86/kernel/umip.c
>> @@ -64,6 +64,8 @@
>> #define UMIP_DUMMY_GDT_BASE 0xfffffffffffe0000ULL
>> #define UMIP_DUMMY_IDT_BASE 0xffffffffffff0000ULL
>>=20
>> +#define UMIP_DUMMY_TASK_REGISTER_SELECTOR 0x40
>=20
> One more thing. How was this value selected? Would it be possible to =
use
> GDT_ENTRY_TSS*8? Linux already uses this value.

I used 0x40 because =E2=80=98sldt=E2=80=99 returned that value on every =
system I tested. GDT_ENTRY_TSS*8 also equals 0x40 (for 64-bit capable =
kernels), yes I can use that instead.


Thank you,

Brendan Shanks
CodeWeavers=