Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp42698ybg;
        Mon, 8 Jun 2020 15:58:08 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyI73FuGlJr8/kbUby+J6tpoJkwVgtKIvbT0/iMeU7vKCT0YhlL6XvFWn//jxXDbbj5ZCW8
X-Received: by 2002:a17:906:15d8:: with SMTP id l24mr22640682ejd.479.1591657088180;
        Mon, 08 Jun 2020 15:58:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1591657088; cv=none;
        d=google.com; s=arc-20160816;
        b=ETtA8KyodorJQBSrvnImOSNY+T72HWRXZaNRycTQNzQrkCd7bdicZS3qkrud0jnPyw
         HtngnJNF8M8wqzvXi8IRTXmxrz72ntGC60rC7YIwDGX0468nzRdEPGNwwRhig2P0gqc0
         utLJU2EjBVMvEKQd0n61w7eArIhGEYS2kfcyyMXoQ5KaAjmePCbJ1dITSA+tO53DrSmq
         AHZpKP6C0/UMJoUrQc0NIsvMWtWf/O4ywp0xwCHG2bPug0emt0MfcnEC0eGzhkwZWAyO
         WOZ9jF2TycwN8sANsA8gyjzh8YjZXM6v4nFvDOV4RcfaRfq9FZU6L7XlqpA2L/I09Tdn
         opjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:mime-version:user-agent:references
         :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature;
        bh=zMV/uWjHJokpFtZM1aSOh01qwGDXaehHDAPbouFNBps=;
        b=X2g7bqlhxfZ7bHVLeCtHz3Gx3Npp1iLNsaDsqkzbiww2T2O3lBjltm6fJyQoo5KVxO
         SfFUpI9dLgs4bwebxI6JtXkFnpojAnIzcNVAzvokUc8lAFvKupOWM9y7ge4qqxk+roqS
         Y2yYdfFiP0bwjzXt25iDKuOCX7zf5adXiK28G6RUom7/OKYjVZt4T07XS4VRnLlDOlGL
         WhpTeAQ3z/jrOSuwpc8i5TkvKvx2COUl+7DpskMYQTdACFpStzZtOK5ZyiSjAe3UiAtJ
         R2fgfcI64OGnPEZRhnCmcrR6seqzhdmZvTL96ZvtEM4jpGQmI/25A7y05xEzT1cWViV1
         G4mA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=vxd2TBIS;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id k4si8562690edn.572.2020.06.08.15.57.44;
        Mon, 08 Jun 2020 15:58:08 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=vxd2TBIS;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726904AbgFHWzl (ORCPT <rfc822;lunatang2017@gmail.com>
        + 99 others); Mon, 8 Jun 2020 18:55:41 -0400
Received: from mail.kernel.org ([198.145.29.99]:40602 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726741AbgFHWzk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jun 2020 18:55:40 -0400
Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id DE7B8206D5;
        Mon,  8 Jun 2020 22:55:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1591656940;
        bh=lmj78NsywzOH58ADrFq/+/zw3NLJPj16X1Kl9wTzZlA=;
        h=Date:From:To:cc:Subject:In-Reply-To:References:From;
        b=vxd2TBISH8H0Cfr4Y2boYussvZELUi1dGQYCN0391gCqf+M+zEHTxMJ3eiBCXwo/m
         Qcaay/hGXQIgfxgQfJp6K0fsW1H0JquhtId6jMP4h7XA9wKQlvbZd8pIDvL8CaAR+0
         VU9uq18isLanuFMVY8NzMiP+1IEas3OaCgSqXiUI=
Date:   Mon, 8 Jun 2020 15:55:39 -0700 (PDT)
From:   Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To:     Christoph Hellwig <hch@infradead.org>
cc:     Stefano Stabellini <sstabellini@kernel.org>, jgross@suse.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        tamas@tklengyel.com, roman@zededa.com,
        Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to
 xen_phys_to_bus
In-Reply-To: <20200608070507.GB15742@infradead.org>
Message-ID: <alpine.DEB.2.21.2006081539550.2815@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2006031506590.6774@sstabellini-ThinkPad-T480s> <20200603222247.11681-3-sstabellini@kernel.org> <20200608070507.GB15742@infradead.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 8 Jun 2020, Christoph Hellwig wrote:
> On Wed, Jun 03, 2020 at 03:22:39PM -0700, Stefano Stabellini wrote:
> > From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > 
> > The parameter is unused in this patch.
> > No functional changes.
> 
> This looks weird.  I'm pretty sure you are going to use it later, but
> why not just add the argument when it actually is used?

It is just a matter of taste. Xen reviewers tend to ask for splitting
patches into small chunks, especially large verbose non-functional
changes like renaming or adding parameters. It is supposed to make it
easier to review, to make it easier not to get distracted by
renaming/non-functional changes while looking at the important changes.
As a contributor, I am happy either way.