Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp54062ybg; Mon, 8 Jun 2020 16:14:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2Q6rAYzEDP6Tx+lQAJOMcl4PU5ap39ddIs7ZMXhMBubzB2lUF1pDMU0YEcaomz0X0jhS+ X-Received: by 2002:aa7:d7ca:: with SMTP id e10mr24715909eds.45.1591658075862; Mon, 08 Jun 2020 16:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591658075; cv=none; d=google.com; s=arc-20160816; b=np7amehdkFI1arr6t3ix5qyuweUX4964je/ANloeqceH6bMP/dVnnMj5Uzwj+jyYsq AlYBHwRW0pHfRnnOBnvJTRoR3pj1iEAaoFlnxnFy0nZdx3/ZqRcZ3LhTUgeERK15eWv8 s+s9Vvdc2lI2NznGLgOyRylfPfOfJb1qHaXA0F2WnnGN8hul7oSd6SrfHIl8y/0r5PUI LamjJxP7yLL8KMWMEh62D9N4bnumBJbPLx+qzcppKrQLnXGriqj4A5OJgGPUl/a8y6h0 tT6F5aWdNrStea9qBeq5xb1t37puSBzdhspRpYmmxCfyhifffBAj+tU/QxcHX5cZrN/G PcCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AvcW6gG2tYrVIUh5oMZKhLihcxYbXoXGgcCo4X+lcvc=; b=mCOmTbdaXmnjtaEBO5jdbna6AbzMCaL/OXYoO2KCKS1MAhRz9UcDcTy/8Tjcc+HJ6u JXXnjd2Ch8MhljHCk24SovzOSLi/vMtMvnf48psczIj3Vs8ATWjR264AxBymXcYW9t0j yx0wkqPPlnysdy1lTX3A6sku+I2B4MhYBy3NmjM0PkcfDcqzmyA6+UuLiula5SgUZ0ct ev5stlC6EANgyA4SOvAg9ktJ1XA5PaAoRUd04IGRNiU4Gl/AdYbUsAQvSmZruGLWw9WB kIwqs8N1ayWsZBMwf1D6vjDk2wCjJBS8eV6sCrZkHxRWQL5gNJYBDhOKhbsptdZYrdQX +W6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l07D7tx7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nm1si9497825ejb.378.2020.06.08.16.14.13; Mon, 08 Jun 2020 16:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l07D7tx7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728756AbgFHXKp (ORCPT + 99 others); Mon, 8 Jun 2020 19:10:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:55192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728419AbgFHXJ2 (ORCPT ); Mon, 8 Jun 2020 19:09:28 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F48020897; Mon, 8 Jun 2020 23:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591657768; bh=9tkCS5V/ET0qK/qSspzqlwj0GfOSKTROamVXeZoqZYY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l07D7tx7z2Ba8/M8Odh7sh4OBIZEo8yeySd93kJTl6v8PlhieYSrwgFTa3yj/CjuN NzItjH24w8dKHCPRF6nC7Q5/hVq6ZAUWZFm6FZG+LebfcidoyAXtfcfUZTmWqUMn0e zX6dv7QT3khwejZThx4LOBaDxi67PAbfg9f/HAY8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wei Yongjun , Vladimir Zapolskiy , "David S . Miller" , Sasha Levin , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.7 152/274] net: lpc-enet: fix error return code in lpc_mii_init() Date: Mon, 8 Jun 2020 19:04:05 -0400 Message-Id: <20200608230607.3361041-152-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200608230607.3361041-1-sashal@kernel.org> References: <20200608230607.3361041-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun [ Upstream commit 88ec7cb22ddde725ed4ce15991f0bd9dd817fd85 ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: b7370112f519 ("lpc32xx: Added ethernet driver") Signed-off-by: Wei Yongjun Acked-by: Vladimir Zapolskiy Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/nxp/lpc_eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index d20cf03a3ea0..311454d9b0bc 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -823,7 +823,8 @@ static int lpc_mii_init(struct netdata_local *pldat) if (err) goto err_out_unregister_bus; - if (lpc_mii_probe(pldat->ndev) != 0) + err = lpc_mii_probe(pldat->ndev); + if (err) goto err_out_unregister_bus; return 0; -- 2.25.1