Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp54469ybg; Mon, 8 Jun 2020 16:15:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7PslZA4TGTmUNGYUP+KR5CGUwML4MzFRZxKFHiUPlyxRkOXTSqS8SAF8g/yd2XbnF9GSB X-Received: by 2002:a50:eb0a:: with SMTP id y10mr24420057edp.312.1591658114253; Mon, 08 Jun 2020 16:15:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591658114; cv=none; d=google.com; s=arc-20160816; b=DuqUSG2vSVP9Ww767J7a1zU85ngirR9aHpeA9hor6hfpheyx6wXgwduYAAzvgX0+S5 3Uln+6gqEuFYNQ4Z04fL1EkQJ7zNokvb3VVFZrI5SXqKz1UoMAQVHyO/kE9OnuJhe+Bn 3ODEr7Ct48qKGT0jsGePJSDm0n2XTKn1BkOZWqACDAUgvQOaLPept8N235Ku8dhFVZ3D k+O0XPK4fONXuAkdbJ/H65HKAffeUAI2dO3ARVD4W0dW54COYNBz5XcRufmkhsQ0QCUO 9JQH3Inpj6Lqf9oWmlS3HjoSHOfGh9lLVIsY6xxuaHZejZxeaLF4rV6AYQe3OO8/G91M vMQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GMjzJef1QVu6fPYWLL2XoMzkjzuuruPjmVxM7o3dCy8=; b=TFqh5S+w6y7zvJ1SMt+1N/KihFq1HsKAnr/JQlfaCFIEshUZjPXCi/GjhPhTG5d2pH DIa8VVBFAOUBgY/aBb23VxkBmUSTuTk+LDLR2RPuiO31kNnK5wKAWIJu78OIRb/mqGoD rPfGCIl2x3dlfnZ+sg7JvwPMz5sG5lTJo2bPpjMajNDpd4Viun5Fu5I1Iu4bmVIEwbNj KPbv0iv1lkw8CTjclm2qsvRDIBEFI3Z9zxPemcUAk2wVAbUVBFuOwv6D7UgoOHDceijo /Q+bUZWcbx0bVZZ2E0JDrO8Y3FdCn9h1Rp9urYZbEeaTVwwZo0XpTuU28SohPo6hI4dW o3WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k5doac0D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b15si8298537eje.741.2020.06.08.16.14.51; Mon, 08 Jun 2020 16:15:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k5doac0D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728576AbgFHXKG (ORCPT + 99 others); Mon, 8 Jun 2020 19:10:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:54818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728345AbgFHXJJ (ORCPT ); Mon, 8 Jun 2020 19:09:09 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6FC9220890; Mon, 8 Jun 2020 23:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591657749; bh=Hun363eN4I4GDgnv/6/COhdFYcOMePNwa8J/7LCfEME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k5doac0DPx8c74LExRa5qpRlKU05BT6ObGaJj21u4ciFh563GEHaIiVQiIjtccs0B VomK2h8dlcpr8RUHu4X1HrcnvNXXrceHn1AM+puhu5xGdbClfMPF+8nlXVA4BgAWlp UGCSWIy9AqsdYgTJktw6AF/PPFkFWZsQ6DHeX2PQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sean Young , coverity-bot , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.7 136/274] media: m88ds3103: error in set_frontend is swallowed and not reported Date: Mon, 8 Jun 2020 19:03:49 -0400 Message-Id: <20200608230607.3361041-136-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200608230607.3361041-1-sashal@kernel.org> References: <20200608230607.3361041-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Young [ Upstream commit c4ed27cfed45c16c2dd16c9fa3b883e306177e40 ] Bail out if registers can not be updated. Addresses-Coverity-ID: 1461655 ("Code maintainability issues") Reported-by: coverity-bot Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod") Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/m88ds3103.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c index d2c28dcf6b42..abddab02db9e 100644 --- a/drivers/media/dvb-frontends/m88ds3103.c +++ b/drivers/media/dvb-frontends/m88ds3103.c @@ -980,6 +980,8 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe) goto err; ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08); + if (ret) + goto err; } dev_dbg(&client->dev, "carrier offset=%d\n", -- 2.25.1