Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751945AbWCVBk6 (ORCPT ); Tue, 21 Mar 2006 20:40:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751946AbWCVBk5 (ORCPT ); Tue, 21 Mar 2006 20:40:57 -0500 Received: from test-iport-1.cisco.com ([171.71.176.117]:31337 "EHLO test-iport-1.cisco.com") by vger.kernel.org with ESMTP id S1751945AbWCVBk4 (ORCPT ); Tue, 21 Mar 2006 20:40:56 -0500 To: "Sean Hefty" Cc: , , Subject: Re: [PATCH 6/6 v2] IB: userspace support for RDMA connection manager X-Message-Flag: Warning: May contain useful information References: From: Roland Dreier Date: Tue, 21 Mar 2006 17:40:54 -0800 In-Reply-To: (Sean Hefty's message of "Mon, 6 Mar 2006 15:41:14 -0800") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 22 Mar 2006 01:40:56.0052 (UTC) FILETIME=[A9A57340:01C64D51] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 26 I added this patch to the rdma_cm branch in my git tree. When I was doing that, I noticed that it builds rdma_ucm.ko unconditionally. It seems that we want this to depend on CONFIG_INFINIBAND_USER_ACCESS, since that controls ib_uverbs.ko and ib_ucm.ko. To do this I rejiggered the Kconfig and Makefile changes I made before. I made CONFIG_INFINIBAND_ADDR_TRANS into a bool (instead of a tristate), so that it's 'y' if INFINIBAND and INET are on, and made the top of the Makefile look like: infiniband-$(CONFIG_INFINIBAND_ADDR_TRANS) := ib_addr.o rdma_cm.o user_access-$(CONFIG_INFINIBAND_ADDR_TRANS) := rdma_ucm.o obj-$(CONFIG_INFINIBAND) += ib_core.o ib_mad.o ib_sa.o \ ib_cm.o $(infiniband-y) obj-$(CONFIG_INFINIBAND_USER_MAD) += ib_umad.o obj-$(CONFIG_INFINIBAND_USER_ACCESS) += ib_uverbs.o ib_ucm.o $(user_access-y) I'm pretty sure this does exactly what we want. - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/