Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp113592ybg; Mon, 8 Jun 2020 17:59:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydpkQdz3sfT8RvxmBYSl2sDAV8FrdpfpzeVlvZ0tSxtnjX4VTtUMxm5HJomuSQ+LK744iz X-Received: by 2002:a05:6402:393:: with SMTP id o19mr25037571edv.28.1591664394099; Mon, 08 Jun 2020 17:59:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591664394; cv=none; d=google.com; s=arc-20160816; b=kJFXG2KWYpqYvNs3WIVZpuM8gAIbI7XGvqDXLA0FlXCCgMQNcaj0ivlw8OJnUpzFPv f+YrX63x73LDnwHj5LL+XbR627CEpYyXqREIyegCyn3q6Tfj+6qlM8GfGkEbkyw3Idw0 4jOTmkB3SflAjPo+jc3TQ2mbjAWsa26O/1ZPe9VBDqKstSYk/b6Gyz1YaS1hb/ladON+ MpOXhg48+uDyVhG/BQ0EU2vV4MNQD+Yulr7unxQG1KO3K9JyCsL4dxZ5zMAMooRvwS4S 0GT/5YeUwVN6hnB7yFOQ/S7JmuZADSJNBbKI63v8+RXHDhcF9DD3lSB5uTzuXEZ6g51M rHrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eNgAH3RSGUHJE8RFGDA6bAuGEz58V7Ai60dLZNt3Tf0=; b=xTQMV6OrLVEq1mYv6cJ7qIbDANFrUJNaCbHzCpVz0BrQu72U7nA8kpp+80k7OXxfee 4K71CjUohgyyhy5q1ud2yKxNGiHHP/9f4IyG6DT7MMyO0mDf3uxHhxWukue2pXHJsLjX nau6bb5Wtby6Rn0ax/cqk7ScRiMxepLNDxx/vb9U8bWMPzlhJwdJrcwW0iu8DaLFQqF+ 6DMX0pfeZ+vc2XfFmI8dLe5giWQLMtGKBd0PS2zsEKXEWdnPKO1aTdq60GpkuoQkzTb6 75qTa+91srQ7Nnh192C101prUPLGFDCHEF3W8wCJTiN+FPXrZSjIQkxXXQpj8CpE4cK/ yQZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AYe+7FSq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt5si13176805ejc.335.2020.06.08.17.59.30; Mon, 08 Jun 2020 17:59:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AYe+7FSq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387987AbgFIA5f (ORCPT + 99 others); Mon, 8 Jun 2020 20:57:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:54406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728265AbgFHXIv (ORCPT ); Mon, 8 Jun 2020 19:08:51 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1CF4E21475; Mon, 8 Jun 2020 23:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591657731; bh=oFIdwIPcbSh6WjyfTNz2t9h1mlmA98OxWyFA46v78Jg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AYe+7FSqRXpY6YsctQaifpSRtMogA1eMZzVPVqMl1GwL9W28tucxa26OlXgyLdM8G 7glcAxO5Ncom+3iuS1M5R+FTVqtoia1cG/FCLh9Grw/SqcRZk5FKJzi5VnluMT58jG y21DT7En6uE8V6iGoyELbo1tAgnznFkbpbX+eg3c= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zou Wei , Hulk Robot , Saeed Mahameed , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 5.7 122/274] net/mlx4_core: Add missing iounmap() in error path Date: Mon, 8 Jun 2020 19:03:35 -0400 Message-Id: <20200608230607.3361041-122-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200608230607.3361041-1-sashal@kernel.org> References: <20200608230607.3361041-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zou Wei [ Upstream commit c90af587a9eee697e2d89683113707cada70116a ] This fixes the following coccicheck warning: drivers/net/ethernet/mellanox/mlx4/crdump.c:200:2-8: ERROR: missing iounmap; ioremap on line 190 and execution via conditional on line 198 Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used") Reported-by: Hulk Robot Signed-off-by: Zou Wei Reviewed-by: Saeed Mahameed Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx4/crdump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx4/crdump.c b/drivers/net/ethernet/mellanox/mlx4/crdump.c index 73eae80e1cb7..ac5468b77488 100644 --- a/drivers/net/ethernet/mellanox/mlx4/crdump.c +++ b/drivers/net/ethernet/mellanox/mlx4/crdump.c @@ -197,6 +197,7 @@ int mlx4_crdump_collect(struct mlx4_dev *dev) err = devlink_region_snapshot_id_get(devlink, &id); if (err) { mlx4_err(dev, "crdump: devlink get snapshot id err %d\n", err); + iounmap(cr_space); return err; } -- 2.25.1