Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp241369ybg; Mon, 8 Jun 2020 22:30:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzW8qP2dKxZGTBUtSF9CVlh5cMJDaI95b5CLhhM6HmhkORp2QMqswOUxzuMND5W/YRa7zEs X-Received: by 2002:aa7:c157:: with SMTP id r23mr13880161edp.139.1591680644902; Mon, 08 Jun 2020 22:30:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591680644; cv=none; d=google.com; s=arc-20160816; b=lBFXI9uKws6UbuvLa62vR7sXVAkKpJCCuUnxkbM6Dlpz1OLGmvmUpOjeExTPnFTuo5 uCCF8fy2SM0QmeDtkeQkKcOkh+i313E2+ew9vqyE6iA8kFJ0gvtJDUxjsYmmkjHtUqXT b+ris5VImjck1WgMT85w6E9LVTy1+RH/BLXkJSzbFiavhaCH8UtIiLYrytX1yt9l0Udu GD8cwgo6KhcDefPqcmL2ZAuDcNsxIG7xpBfQsAgMfV+o+jTGadFV/FblM++FiXw+ariY YsQvGj9mn5P1kjv+zIHpHVa7sioM7eAZYmKs+4ek3RWRX0bUUokrzoAWbWkohrRWB5YL XvhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:references :in-reply-to:cc:to:from; bh=H6Iq+fFjZMtsQnY8cW/XnxNsnKSB+wvKAFjTJaVlebI=; b=nqAItxr7B9CmStTKS+BTPuo0bs4vFHemgjGRvYTRbUzwXT0gLPypUWGPlcuzK3XbOH GSB9feeH3+0M67nMjKqcy9roTKnxeJ+Tz0PXROc5ZPJweq+KpR8UXByLlxuoqrrRNmRB n2prpotPOAGbEyT/aEZgw8/HeKZfNE0UK+yj04SpD2bkjjEX24slcgUFXMyoYR4s01yc rAefd856O90NzjYIjfse4ybyCcz3Heyq8QvJg0EWZ83mxtd2blElJFdKzpuuOJvoTh1O R87878NVDLYaVL2Ub34VvYTH5271thMNvtrnbglQExHei05b7kTEnXQOMgyoRHOiqtVZ DmRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si10156281edn.68.2020.06.08.22.30.22; Mon, 08 Jun 2020 22:30:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727088AbgFIF2i (ORCPT + 99 others); Tue, 9 Jun 2020 01:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbgFIF2h (ORCPT ); Tue, 9 Jun 2020 01:28:37 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52B19C03E969 for ; Mon, 8 Jun 2020 22:28:37 -0700 (PDT) Received: by ozlabs.org (Postfix, from userid 1034) id 49gzDf6lyCz9sTH; Tue, 9 Jun 2020 15:28:34 +1000 (AEST) From: Michael Ellerman To: mpe@ellerman.id.au, Qian Cai Cc: linuxppc-dev@lists.ozlabs.org, rashmicy@gmail.com, linux-kernel@vger.kernel.org In-Reply-To: <20200306044852.3236-1-cai@lca.pw> References: <20200306044852.3236-1-cai@lca.pw> Subject: Re: [PATCH v3] powerpc/64s/pgtable: fix an undefined behaviour Message-Id: <159168031307.1381411.14671547649283777399.b4-ty@ellerman.id.au> Date: Tue, 9 Jun 2020 15:28:34 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Mar 2020 23:48:52 -0500, Qian Cai wrote: > Booting a power9 server with hash MMU could trigger an undefined > behaviour because pud_offset(p4d, 0) will do, > > 0 >> (PAGE_SHIFT:16 + PTE_INDEX_SIZE:8 + H_PMD_INDEX_SIZE:10) > > Fix it by converting pud_index() and friends to static inline > functions. > > [...] Applied to powerpc/next. [1/1] powerpc/64s/pgtable: fix an undefined behaviour https://git.kernel.org/powerpc/c/c2e929b18cea6cbf71364f22d742d9aad7f4677a cheers