Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp366537ybg; Tue, 9 Jun 2020 02:40:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygyM6/4oTAE0F0EpnF9+CHtnP4uM7XibvpD+m5S4rUzh+1St37YaspH07HuTb0FEHDe7wv X-Received: by 2002:a05:6402:22b3:: with SMTP id cx19mr25366662edb.329.1591695608173; Tue, 09 Jun 2020 02:40:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591695608; cv=none; d=google.com; s=arc-20160816; b=n6xE44Vg7FDE1op4YC5pCpq2ON762xyScjiml+Vbi26GdyIhPTu4PKMTbfYiKB0ZkI e9Cw8+YUTnxZP6sQHHZX4X3A2aiNgvdOv+WPL64IkhW+gDU9m2IrV/Fqu7ZEJ2YfRLnH +58rVAWtK0EDCkkcsmZyFvdV2ttl5EZfR9eMzy1V1rSkbvYhNbY2kZSRi45l9BHYFPV/ BbregSgBaRRRC+GUo1AfA8tDFHT9focGK8KOEhklgpZWFAk5Dp6jq+N5dX6SiFYph0DG +n8g+IvLAPDDbeItBZ1fZSa0d9F25Kv3ZvyCvz3s3qYhZGWLF9X2NQUH4qlQ4EQyzXoz GF4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:to :autocrypt:from:subject:cc:dkim-signature; bh=DMvINLdMtPZlNsoIOPUi6ULGlM6FIdQLtzCxVu+IOKQ=; b=sAJAVWHZrqJnDPS705uZg5rlTeSBHkWibMiiBUPb8G0yzM27YkBsYis+eIRi1BeT2b 5fEibyFryafCfhEmje3NM5l+oGHZ4F1OaXupd0epeGI6/E65ZLJ4DapPR1Sfb1cE5r2o N7/JNIasG2kx58fpj3pdzVArpjjU7lpkVkilSYdkB9MJNagH7CcgSkzM3Bh8D5mVMJFn gSeUaZwJTYzYhuIGIAOS7JixIYFA+KXqXIspE6wIJkOZdK3mZYL2/J7cu6KTGa9fwPgY CrHstSe+Hcu30Ex3fSADAhuo5BEtQu1rQiGV1P6I00OYxH0dTJA+RDzKiYlne/yeuT70 CO6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=lK+45rqX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id di18si10414884edb.564.2020.06.09.02.39.44; Tue, 09 Jun 2020 02:40:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=lK+45rqX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728497AbgFIJg0 (ORCPT + 99 others); Tue, 9 Jun 2020 05:36:26 -0400 Received: from mout.web.de ([212.227.17.11]:58071 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727086AbgFIJgV (ORCPT ); Tue, 9 Jun 2020 05:36:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1591695371; bh=NpSwO6xMFBw8TDKDNbh3ZtFdFhrLZFzYnTF7UJssoFM=; h=X-UI-Sender-Class:Cc:Subject:From:To:Date; b=lK+45rqX6Fc7flnJKFO5plwbq8zR42zPEvB1icZgGK8LGOiihxFaI4k2QgdW8as1y lj2p5hngN7Su+mAsfnImFtZKqWBcbvfftpINCzbJsH17R1x9nyzQFpE29BvHoajETp bGft9SFOQXQyw6wpS/J5z+FP5LB3d//qWec3/91w= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([77.6.55.3]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N0Icn-1ilWsW2Q6B-00xFxk; Tue, 09 Jun 2020 11:36:11 +0200 Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] coccinelle: api: add selfcheck for memdup_user rule From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= To: Denis Efremov , Coccinelle , Gilles Muller , Julia Lawall , Masahiro Yamada , Michal Marek , Nicolas Palix Message-ID: <675f3bc3-99f4-1780-af04-cf7de2e9059a@web.de> Date: Tue, 9 Jun 2020 11:36:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:7CeUvxCUQ6EJKnHmYxZyFtswKqKjx7kdOjE/wFEB1/nj6KWdiqf YJDX0kicge1A54j8VpqHqMvaDp8W2HUMuCwWCbn8B8pi3lnKAn6Icv57v8lMAjgHr6A4cq/ 2jXmpjt/UDRG6HLQDMT1xqzgBUSgrI3hbDfJCUuccwnHzDzi95nPZ7g6bP5amsW2cDV61v5 ZynDy7TTK8bDk1MinJq+Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:AfBzq1DY0VU=:BQZxKX84v1cpxQsKIW4lG4 7f+1ZVpSMBb4+leC47n/K+2TYUVg8JDLZiaXiX3D1rKbFN/6Noz/ozif+b5AGlRF5RUCGYpiS SbrTMWLTpMXNuXa9YuiW/gWtAnNccJicT8jtm6RqUCrr9C6RFOYZTH6CxSvng7m8mXEPVPJZE JJQKl8h86fVjkn/wZymV3oQQBiuBYq1K9ohKtxTkvl+QsoYjO/uSkGadibOHlj3K5PXBw4zDD gH8LnUwgSNbmP9I4uGYCN4kItJDENB+AA2EYrKtu8jcclsk7nhxKIM0waD3y8vaOPueRlYsJd FZjztEn5sO7vor6cF/jI0BrXFZk4s8AITttPXk4O39/Mqi+xeyALq9MPEeHUQMQjqko4uty6U kMnK81a+i09U8MsmxBhuZRcrO69uks/lCjukWMXm5RfM9XnkjwtYGF3/JzmrUPqC2jY9rPc7d YpSnHYjHN8M6CwdtGMh1A1605JxHtfzAp5X4h2Hwl6Ru5kiqnLXQ0+HiyUH47f67QD+VHYcIz Hkq7SrgDE3HBbBWvJXXzF8I99z4Uq2LQvGaiJF3+51MnBN7I1qIZAsTdue6OXLN+Pd0r7gV7y U2GNlwMca35pZrxdUQyINm2AM18DyJ/RHKZzHTkWxM9fJB2WsmoKTkaKtg0jN7GNS1zLXeqYW h2DB+xM9haoAgNkw2AfcGTCBU70ZGpnH9QJz3GrvrHh9aj+jtrb3bEZL6cFqesAg2VYBuvhDk 4AmFNMjc5nN9x1tU2Ez0sFcMXaffGPOE9uPQb40JDBGIWFjxClk3cN7cE2w5AttNlksrmnMwI hAKGg/H/1odZ9Y+GVEQ4D8GjU1LDNRhslSrg/YPUozeWdyiM1NWQB+1AKHiGXNnWajlkhOQaT 8ZCS1tD/shfqNBn7U44IUK2j2sGjvLdM/+jtbYwyZHmnLa2e2AFscYjnvnMySHIFGxZI5CrYR cVZ1t0U3DmTKNqBbq7wVqV63F7lgmPa3irVrOa2tVzmZlxQB0Ij/4cflU7IvrBANvIY1DVBvF 9Utt+4zQmd0Yrexh8a2YkqaDh68AN3xmRgeY4VMqEJVbuZlR7UMTMM/SV5TH3DeM2gi987xZy RjMDlW7Ok6FE8XCmEx9ba+QCn4r4Va82DW1a0Vl4EG770ejnRFJsAMbEtdIvHNntduAcVJ7Ev 2YafDIB26xITvu+zQJgfTR13o59ZtbBNsh8j76bBqHHG952TH/nn7RmyVRZ/XNhI0tckOmlA4 OE22034hzyDRSev2X Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E2=80=A6 > +++ b/scripts/coccinelle/api/memdup_user.cocci > @@ -14,13 +14,24 @@ virtual patch > virtual context > virtual org > virtual report > +virtual selfcheck Would you like to avoid the repetition of a SmPL key word here? +virtual patch, context, org, report, selfcheck > @@ -117,3 +128,34 @@ p << rv.p; > @@ > > coccilib.report.print_report(p[0], "WARNING opportunity for vmemdup_use= r") > + > +@script:python depends on selfcheck@ > +@@ > +coccinelle.checked_files |=3D set(definitions.values()) & set(cocci.fil= es()) I suggest to reconsider the usage of the function =E2=80=9Ccocci.files()= =E2=80=9D. Can such a script rule determine for which file it should perform data pro= cessing? > + print('SELF-CHECK: the pattern no longer matches ' \ > + 'definitions {} in file {}'.format(not_found, efile)) Can the following code variant be a bit nicer? + sys.stdout.write('SELF-CHECK: The pattern does not match defi= nitions {} in file {} any more.\n' \ + .format(not_found, efile)) Regards, Markus