Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp405309ybg; Tue, 9 Jun 2020 03:48:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5lHQgeA8zdoKLURuxJ0s8FTxNkT3D5M67VA7YEo+Cait2KCCmWadWNR+NB+khymPHhwrw X-Received: by 2002:a05:6402:b8a:: with SMTP id cf10mr27041669edb.138.1591699683507; Tue, 09 Jun 2020 03:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591699683; cv=none; d=google.com; s=arc-20160816; b=hyfrCkeck9GMO8TUf20yUQMHhWq+ood4ybcWuM2hU1L70Qonwv/RcjHd02mVRj821+ U+jKJE9qh1mvN9CeP8l6ilUvJeWPPfQU/H/rNCK6S1H4aMXv/DIWpu0Yfh1onbdbT4Uu mCQbB5LTFqDZkYmopNpIfVv/X9c1wwypu4La5L1MCljbkexOdNk++vJD856+5f3IsHLa s6CCpG4VKS0J0Jh83XKKIFpOu/NcoX9d+h7bzcjaRdLVXIiWnmeEZjUG7Innn8kfTbjN jduNQ4PywPJaDIQd8Zpz38aY9P0g8RBLtuOYb5RdZBu7h5kyyONsUC4Wg/5b1oOFT4QZ n0rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:to:subject; bh=xVxSnb0JQE1YNMvQ5+klCQX0HJrvSLEG4kihjy08Qh8=; b=XNFXifobce1NkiqCXevSs3L1plM9k2KwM+BEPqu0dfiqYFrwb6H2yXD9cdhU7+Rd5x 91N6yEv8H1iLe+/edv5XmpZ4GwoiQYJjMPYdNboeuERN2IPebaGwrOhRza7jdeAfcqcY xnB2Bj31E1x28VZ0lNsu6jjDGIFhSwxmLvUpsPGN97e+Ar4uSzfyLq1Qpt3sf84neE2K 2kABdOwwnG0a7SjOrRfiR6uBnE4KtgsZW+YW8HCL8QUdL22pjAJkXDEb5M6koQAhdohP oUP4fgG0nJnY5eB7AlBagb5ePJjtNWXKZ5iBTPVXOX07Ueg1HEzXPeJo44j+PhwPToEO FXPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si11041578edz.508.2020.06.09.03.47.40; Tue, 09 Jun 2020 03:48:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728347AbgFIJPt (ORCPT + 99 others); Tue, 9 Jun 2020 05:15:49 -0400 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:52799 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbgFIJPt (ORCPT ); Tue, 9 Jun 2020 05:15:49 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07484;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0U.3kARo_1591694145; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U.3kARo_1591694145) by smtp.aliyun-inc.com(127.0.0.1); Tue, 09 Jun 2020 17:15:45 +0800 Subject: Re: [patch 113/131] mm: balance LRU lists based on relative thrashing To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, mm-commits@vger.kernel.org, riel@surriel.com, torvalds@linux-foundation.org References: <20200603230303.kSkT62Lb5%akpm@linux-foundation.org> From: Alex Shi Message-ID: Date: Tue, 9 Jun 2020 17:15:33 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200603230303.kSkT62Lb5%akpm@linux-foundation.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2020/6/4 ????7:03, Andrew Morton ะด??: > > + /* XXX: Move to lru_cache_add() when it supports new vs putback */ Hi Hannes, Sorry for a bit lost, would you like to explain a bit more of your idea here? > + spin_lock_irq(&page_pgdat(page)->lru_lock); > + lru_note_cost(page); > + spin_unlock_irq(&page_pgdat(page)->lru_lock); > + What could we see here w/o the lru_lock? Thanks Alex