Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] powerpc/pseries/svm: Remove unwanted check for
 shared_lppaca_size
To:     Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
        linuxppc-dev@lists.ozlabs.org
Cc:     linux-kernel@vger.kernel.org,
        Thiago Jung Bauermann <bauerman@linux.ibm.com>,
        Ram Pai <linuxram@us.ibm.com>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
References: <20200609105731.14032-1-sathnaga@linux.vnet.ibm.com>
From:   Laurent Dufour <ldufour@linux.ibm.com>
Message-ID: <183e9acb-4562-af7c-a50b-52cee5954d9e@linux.ibm.com>
Date:   Tue, 9 Jun 2020 14:25:49 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200609105731.14032-1-sathnaga@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le 09/06/2020 à 12:57, Satheesh Rajendran a écrit :
> Early secure guest boot hits the below crash while booting with
> vcpus numbers aligned with page boundary for PAGE size of 64k
> and LPPACA size of 1k i.e 64, 128 etc, due to the BUG_ON assert
> for shared_lppaca_total_size equal to shared_lppaca_size,
> 
>   [    0.000000] Partition configured for 64 cpus.
>   [    0.000000] CPU maps initialized for 1 thread per core
>   [    0.000000] ------------[ cut here ]------------
>   [    0.000000] kernel BUG at arch/powerpc/kernel/paca.c:89!
>   [    0.000000] Oops: Exception in kernel mode, sig: 5 [#1]
>   [    0.000000] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries
> 
> which is not necessary, let's remove it.
> 

Reviewed-by: Laurent Dufour <ldufour@linux.ibm.com>

> Cc: linux-kernel@vger.kernel.org
> Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com>
> Cc: Ram Pai <linuxram@us.ibm.com>
> Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Cc: Laurent Dufour <ldufour@linux.ibm.com>
> Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> ---
>   arch/powerpc/kernel/paca.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/paca.c b/arch/powerpc/kernel/paca.c
> index 949eceb25..10b7c54a7 100644
> --- a/arch/powerpc/kernel/paca.c
> +++ b/arch/powerpc/kernel/paca.c
> @@ -86,7 +86,7 @@ static void *__init alloc_shared_lppaca(unsigned long size, unsigned long align,
>   	 * This is very early in boot, so no harm done if the kernel crashes at
>   	 * this point.
>   	 */
> -	BUG_ON(shared_lppaca_size >= shared_lppaca_total_size);
> +	BUG_ON(shared_lppaca_size > shared_lppaca_total_size);
>   
>   	return ptr;
>   }
>