Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp490860ybg; Tue, 9 Jun 2020 06:01:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzarMcoqqyjE4Oj1+pgkdXtzLab/wCIj+M/B0P0v6SHnPRuwnO5p+8xN05Td6YO6zU4B8pQ X-Received: by 2002:a05:6402:1243:: with SMTP id l3mr27469476edw.64.1591707702636; Tue, 09 Jun 2020 06:01:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591707702; cv=none; d=google.com; s=arc-20160816; b=DNbrN2vH6wCNTCK0W6newz9VOC3Nj4mt10z5fjc9dAAmb6TZBBevFQdFqqd/scDJKJ xp2Go31h4lkt2oVmN1EbIWI4ydQzUiLa+YzkizS3dRmitdHh3nG1EB4B58KeC9OFptcl UfWHwMcxMvdEPGRjcnHzxve6mP5Suj6Wqey9vQpTLuO0TIGWrIi3ws8GyMVYE7W6yBch xADAgZCGpWeTxkyAPugOruwhfXoeRgfE1aytuxknPmBOz7pKtUdubSeIWAKdFbViQjYw I6NswEUGhfRpX+qGeHcx/vSIpxSkY15Nzzey9CqbwGioHQ+8st2LSQLMZtPN9+JcPYJr 0eXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:in-reply-to :subject:cc:to:from:references:ironport-sdr:dkim-signature; bh=FcmEwi2slS5ZcwK6rHuvNoaejIXBee/EH3bb9uBAZ1M=; b=CvlTOC7rPuR+BO7wSSHs3G1iXpP/CN0QZkmd2IZBW71anVOv3KhEENXnDk18RO1dHx SZVTP8Ef7nXCGAgY0ASRED7kM2fICPFspdtklDB5fzumxkvCXoOuex5Ua12O5sqV6oJa Iw/5gzvHQeyxDLOm5jC/8OCZnPutAXDL6K2ecbY7fALf5QNJ58Io9rFA5o1eL2TAQ7gW L0Y3/T84+Ydj/nXIZl2AX7TG9wlUmAcYvj9d990sclI1tO0/alwcV0rOqobdngHx6yuh It86C/x7Liq/CI2MvjWd3255bN8rsxdOihwlQFkXDn4wiVFuJKDzodGg9fW8Tw6FqVAX 3SdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=liv9i5S2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rh3si10516882ejb.539.2020.06.09.06.01.17; Tue, 09 Jun 2020 06:01:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=liv9i5S2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728431AbgFIMzC (ORCPT + 99 others); Tue, 9 Jun 2020 08:55:02 -0400 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:57913 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbgFIMzB (ORCPT ); Tue, 9 Jun 2020 08:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1591707301; x=1623243301; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=R4d1xFOQANOtBvYugE4Y6z/1+LM4tG8caBxOeDEyPCg=; b=liv9i5S21PCOej3E82Sz/28uPN/9ah9nZQivmnSduccmsFjY5M5kNyTr 4ytXdZ7vbejVr7rVi4nnU/l3wGAld79jiqmvesgXFW5ZoO18euoSoElT8 Y0HWp1EtxQ8of/sX8sO7l25fB8u7eam/hNrB6QIJzBVk6jm+DuztciVQ/ jvShsyYeGqgHCS/nQ4PqZs1XAW55PkFYBY8UxUcnsRIwKJR4/7TjIhh3n g7Aqxp0Iod9z2GlpQdS1U7Ke8+cWq4k/OOYgShW+1R2gj+Ea4KSKBFz1S ysnP+xyEJ9YwYyZkyZcjfdkt5qX61JQVt37cXDNHHHmAf8888iXZ/LtJ+ A==; IronPort-SDR: WAUKnIXpcUbDouBuOz024F5bSzIZ7+iHnxZeWI8QHby6MNWMIDw5pmk2jj7PVMdBKyPVy4b81W G2ktMI+O5H2bocpkSKi/DiHgvq2xQNE3wrNGF44mZhvL8AwD6GXlSJTS31FRmgqh1h6oKU5l6q cBV3erkFaKmMlCnUKLxsDHoePKE46e4UA3nTOGz/4hlr+BYDH8+TJKsR31BRclTeuc3OjHcRVk SL0aiMMVWITHhn41N73LPpgA8f6MFnevuSJ/xkG4MG0YZIamcdGmV8Gnwk4D0lyhE29g6mFHpO /ak= X-IronPort-AV: E=Sophos;i="5.73,492,1583218800"; d="scan'208";a="79427220" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Jun 2020 05:55:00 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Tue, 9 Jun 2020 05:54:59 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 9 Jun 2020 05:54:57 -0700 References: <20200609072828.9088-1-lars.povlsen@microchip.com> <20200609074940.9529-1-lars.povlsen@microchip.com> <20200609093808.00003aad@Huawei.com> From: Lars Povlsen To: Jonathan Cameron CC: Lars Povlsen , Guenter Roeck , , , Alexandre Belloni , Jean Delvare , , Microchip Linux Driver Support , Subject: Re: [PATCH v2 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver In-Reply-To: <20200609093808.00003aad@Huawei.com> Date: Tue, 9 Jun 2020 14:54:56 +0200 Message-ID: <87ftb4ielb.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jonathan Cameron writes: > On Tue, 9 Jun 2020 09:49:40 +0200 > Lars Povlsen wrote: > >> This patch adds a temperature sensor driver to the Sparx5 SoC. >> >> Reviewed-by: Alexandre Belloni >> Signed-off-by: Lars Povlsen > > Hi. Quick drive by review whilst waiting for coffee time... > > A few minor suggestions inline. > Ooops, forgot to ack the COMPILE_TEST and bitfield.h suggestions. Both adopted. Thanks, ---Lars -- Lars Povlsen, Microchip