Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] soc: imx8m: Correct i.MX8MP UID fuse offset
To:     Anson Huang <Anson.Huang@nxp.com>, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        leonard.crestez@nxp.com, abel.vesa@nxp.com, l.stach@pengutronix.de,
        peng.fan@nxp.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     Linux-imx@nxp.com
References: <1591708550-14058-1-git-send-email-Anson.Huang@nxp.com>
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
Message-ID: <7a4091c5-dc57-31c3-3445-c6b16a565928@nxp.com>
Date:   Tue, 9 Jun 2020 18:23:49 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
In-Reply-To: <1591708550-14058-1-git-send-email-Anson.Huang@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.6] (86.121.160.118) by AM3PR05CA0132.eurprd05.prod.outlook.com (2603:10a6:207:2::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18 via Frontend Transport; Tue, 9 Jun 2020 15:23:51 +0000
X-Originating-IP: [86.121.160.118]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 363bdcf2-e491-43f9-100d-08d80c891e11
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3519:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB35194922A4F1E118B948EBC98C820@VI1PR0402MB3519.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1060;
X-Forefront-PRVS: 042957ACD7
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 4Bp1dFdWswmWWDOaoYxvoRXmqD50rygUdCfrQ37+MN1CM6qSRYFpJXKQ9X25FFg0MoiuxLurx0ni2EA38pyLJn1+qHiFOTwHVmQ13Lypz/5vDLKe46QDOgLTJSWf79qXa8qEi3EYO5ygJT8BcMu2zLOP2YQHlvVbp9p0KE+huK+/NSxbca2nCwCcnx4iuBo71zyys9wMDKgc/bitkJaQJEgUwyhDGG+6fZoPsi+kMW+alb3Dop9RtvKlBLwmpiLObkKaszqd0eAPQKF/ozJU7rxEIXHqOOcA85MS/XI5aUGNOIq7rXnQ4ohO8bCqcvWYV+sa/bg7GQ9cdWDmEtGyLuCFHUpbEQ1nKu8zIJyircElV0q5+QaxLV/zT5xlmMebDqT59g44gEGldqJ18RaNvsqsB3LfdgvNwDpMjmq0yVc=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3712.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(366004)(136003)(376002)(39860400002)(396003)(86362001)(8936002)(66476007)(66946007)(31686004)(66556008)(83380400001)(2616005)(31696002)(5660300002)(2906002)(8676002)(36756003)(956004)(4326008)(16526019)(44832011)(186003)(26005)(52116002)(16576012)(316002)(6486002)(478600001)(53546011)(32563001)(921003)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: 6XVzbktVP64DN3wBl957K0sEOkQ42L4jD+3kqv8Pu4ILl8zJCwQc8EUGZLJ7F6S922pwb6DldAZ3zB9bnly1pZGB0UoXLpE6lBsTDTbXTfSwMxof7UgBvMnrAIL0eXhigzghn1PHdPBqnPvvrfbDVsV0BYs0h0mTs5wehHStR1SNTDA9K6T7X9jcdkAhiVcsj8T4YTpl6xEzKDUOXEoHPHpklZCJX6+OWjXU6Gr7ur1bz9SgECMAmht17Ner2vWuyjB3MN4GOjqiO0OTJd3c9Dwr4dxnV/gisigSFghk9gLMySArOZ5zWKxkzUuP+4km2RotPx6Ab4ft7jX72iUS/Dh8ohv12/fhmRYQolapF6GWvFV9sCt1EF2RRBGghVGjDjZe33LQjcwXOX6VET3QtqE6pd68bR+JomwN2OT2ZECBFoY3lEQbTkHmZMhK9z7XKZfikZKafX4+tMuStDaoU8beG7znQhGu6SJMAH7u5Nmhe8RHIfGVzAOQqf4et7gL
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 363bdcf2-e491-43f9-100d-08d80c891e11
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2020 15:23:52.9441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FEb1+RMwBv20aDKruh1EypjPNnlgKW5AaspWe8/REE2dyvAopBlDlcKbUdeyWUQjh2halI94M6CzXyQy/J4PYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3519
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/9/2020 4:15 PM, Anson Huang wrote:
> Correct i.MX8MP UID fuse offset according to fuse map:
> 
> UID_LOW: 0x420
> UID_HIGH: 0x430
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

If this patch corrects the imx8mp UID shouldn't have a Fixes tag?

> ---
>   drivers/soc/imx/soc-imx8m.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 7b0759a..0bc8314 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -22,6 +22,8 @@
>   #define OCOTP_UID_LOW			0x410
>   #define OCOTP_UID_HIGH			0x420
>   
> +#define IMX8MP_OCOTP_UID_OFFSET		0x10
> +
>   /* Same as ANADIG_DIGPROG_IMX7D */
>   #define ANADIG_DIGPROG_IMX8MM	0x800
>   
> @@ -87,6 +89,8 @@ static void __init imx8mm_soc_uid(void)
>   {
>   	void __iomem *ocotp_base;
>   	struct device_node *np;
> +	u32 offset = of_machine_is_compatible("fsl,imx8mp") ?
> +		     IMX8MP_OCOTP_UID_OFFSET : 0;
>   
>   	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-ocotp");
>   	if (!np)
> @@ -95,9 +99,9 @@ static void __init imx8mm_soc_uid(void)
>   	ocotp_base = of_iomap(np, 0);
>   	WARN_ON(!ocotp_base);
>   
> -	soc_uid = readl_relaxed(ocotp_base + OCOTP_UID_HIGH);
> +	soc_uid = readl_relaxed(ocotp_base + OCOTP_UID_HIGH + offset);
>   	soc_uid <<= 32;
> -	soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW);
> +	soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW + offset);
>   
>   	iounmap(ocotp_base);
>   	of_node_put(np);
>