Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] sample-trace-array: Remove trace_array 'sample-instance'
To:     Kefeng Wang <wangkefeng.wang@huawei.com>,
        linux-kernel@vger.kernel.org
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
References: <20200609135200.2206726-1-wangkefeng.wang@huawei.com>
From:   Divya Indi <divya.indi@oracle.com>
Message-ID: <cd3f1c60-ae0f-8932-7096-95da5f6d419e@oracle.com>
Date:   Tue, 9 Jun 2020 09:30:49 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200609135200.2206726-1-wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Divya Indi <divya.indi@oracle.com>

On 6/9/20 6:52 AM, Kefeng Wang wrote:
> Remove trace_array 'sample-instance' if kthread_run fails
> in sample_trace_array_init().
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  samples/ftrace/sample-trace-array.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/samples/ftrace/sample-trace-array.c b/samples/ftrace/sample-trace-array.c
> index 9e437f930280..6aba02a31c96 100644
> --- a/samples/ftrace/sample-trace-array.c
> +++ b/samples/ftrace/sample-trace-array.c
> @@ -115,8 +115,12 @@ static int __init sample_trace_array_init(void)
>  	trace_printk_init_buffers();
>  
>  	simple_tsk = kthread_run(simple_thread, NULL, "sample-instance");
> -	if (IS_ERR(simple_tsk))
> +	if (IS_ERR(simple_tsk)) {
> +		trace_array_put(tr);
> +		trace_array_destroy(tr);
>  		return -1;
> +	}
> +
>  	return 0;
>  }
>