Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp681405ybg; Tue, 9 Jun 2020 10:07:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJym8jdbYDJFx3OQSdCWTVENqlk9aaxalpzbacXIPQNi05IsTFAG0fQT0R7wAh9d0IM+PT8B X-Received: by 2002:a17:906:2a94:: with SMTP id l20mr2375541eje.224.1591722466809; Tue, 09 Jun 2020 10:07:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591722466; cv=none; d=google.com; s=arc-20160816; b=rpyf/x9A3OwCpWCqkxZ1qzlE5d99yOwVBZuSMDMYYg+pp13R9utwal9V7uU3IREyYa pFx8p1+S1oW19bUYUrmhj3OD5Tuzyr7qeOP9vfK+638qxY/LXno20uI4jFR3ek8Tj2VL 5bWR1Olx29MPUFjiIB2TkLllkbMCfRhMaNY8Ks4uF4qRF9OG2v00fq3pYRbPW5pjGRY3 eaiFx+AObf9Q4TwXYBnxZ124WuakUVV0pwIKIaaJitMR2Da/ozMSLDmwL3rHq59QGaJu zY6T7JRkKTu3sSyW1DAKZ0RMJR5hBqkLyCRfkmW5rFqwAIMsTOVcxbofRz1T6bMRVHMA jhlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=efKFo+rgUSSlmzfRTLleMg8ZTyEBR6um9JPMJby6i1E=; b=xrU7rztjU2Y7UMjMscKpDlOJW5uZX2Q6nsrW5H9J2JflP6lJJu5BsMU3AxybgHV4nG yQ44uRKudSWP7qM5JUnD8bkGuCrw43keEPini4wK3LV4BKXLAC7e0WatqugHTax06PFs UQr/5qC6PjVw9pWK/WB802TPd+kx0ohDt0/JQWM+g69WwyuXBf8Ct7ZcHwiNG/5EJ0yf Jj5ggoeCahC4lXHykk/A+xuntujAWJPMTEQm09hxEVpztK+KKy3boGxQnpjHXPzu002n IrF3VVwc+0JYzPQgtmgRobKRXi3dgPQJuwM6CKIXV9KhbFrmnfrecQq0fZUTVYVonsK8 IV5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v14si1716647eje.123.2020.06.09.10.07.22; Tue, 09 Jun 2020 10:07:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728445AbgFIJSb (ORCPT + 99 others); Tue, 9 Jun 2020 05:18:31 -0400 Received: from mga03.intel.com ([134.134.136.65]:4040 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728436AbgFIJSa (ORCPT ); Tue, 9 Jun 2020 05:18:30 -0400 IronPort-SDR: l0dkD4nT8XHCetHA3RgUdpJqp2DQm3OPI76qYbZP7YDGIv9GZtASe5HhXQaUsTEawbi0SXJ4hx jU+X58FaQ8yw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 02:18:30 -0700 IronPort-SDR: +olPD0zhM290Umf18+sPDZZPw+ga0IPL2XIZkaoeeqo0oJ41smWh9kqflrscC/dJF2qDz6FjPb 0bIpyVbyCFaw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,491,1583222400"; d="scan'208";a="314149665" Received: from gklab-125-110.igk.intel.com ([10.91.125.110]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jun 2020 02:18:27 -0700 From: Piotr Stankiewicz To: Bjorn Helgaas , linux-pci@vger.kernel.org Cc: Piotr Stankiewicz , Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Arnd Bergmann , Andy Shevchenko , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate Date: Tue, 9 Jun 2020 11:18:22 +0200 Message-Id: <20200609091823.1346-1-piotr.stankiewicz@intel.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20200609091148.32749-1-piotr.stankiewicz@intel.com> References: <20200609091148.32749-1-piotr.stankiewicz@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it. Signed-off-by: Piotr Stankiewicz Reviewed-by: Andy Shevchenko --- drivers/infiniband/hw/qib/qib_pcie.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c index 3dc6ce033319..caff44d2c12c 100644 --- a/drivers/infiniband/hw/qib/qib_pcie.c +++ b/drivers/infiniband/hw/qib/qib_pcie.c @@ -213,7 +213,7 @@ int qib_pcie_params(struct qib_devdata *dd, u32 minw, u32 *nent) u16 linkstat, speed; int nvec; int maxvec; - unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI; + unsigned int flags; if (!pci_is_pcie(dd->pcidev)) { qib_dev_err(dd, "Can't find PCI Express capability!\n"); @@ -225,7 +225,9 @@ int qib_pcie_params(struct qib_devdata *dd, u32 minw, u32 *nent) } if (dd->flags & QIB_HAS_INTX) - flags |= PCI_IRQ_LEGACY; + flags = PCI_IRQ_ALL_TYPES; + else + flags = PCI_IRQ_MSI_TYPES; maxvec = (nent && *nent) ? *nent : 1; nvec = pci_alloc_irq_vectors(dd->pcidev, 1, maxvec, flags); if (nvec < 0) -- 2.17.2