Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbWCVJ4N (ORCPT ); Wed, 22 Mar 2006 04:56:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751175AbWCVJ4N (ORCPT ); Wed, 22 Mar 2006 04:56:13 -0500 Received: from mailgw3.ericsson.se ([193.180.251.60]:2497 "EHLO mailgw3.ericsson.se") by vger.kernel.org with ESMTP id S1751174AbWCVJ4M (ORCPT ); Wed, 22 Mar 2006 04:56:12 -0500 Date: Wed, 22 Mar 2006 10:56:06 +0100 (CET) From: Per Liden X-X-Sender: eperlid@ulinpc219.uab.ericsson.se To: Jesper Juhl cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] cleanup for net/tipc/name_distr.c::tipc_named_node_up() In-Reply-To: <200603190045.24176.jesper.juhl@gmail.com> Message-ID: References: <200603190045.24176.jesper.juhl@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 22 Mar 2006 09:56:08.0600 (UTC) FILETIME=[D7B47980:01C64D96] X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 28 On Sun, 19 Mar 2006, Jesper Juhl wrote: > Small cleanup patch for net/tipc/name_distr.c::tipc_named_node_up() Not sure if you followed the discussion on the tipc mailinglist, so here's a short summary. > Patch does the following: > > - Change a few pointer assignments from 0 to NULL (makes sparse happy). Ok. > - Move a few variable assignment outside the tipc_nametbl_lock lock. Ok. > - Make sure to free the allocated buffer before returning so we don't leak. The additional kfree_skb() looks incorrect. If a buffer if allocated it will later be released by tipc_link_send(). /Per - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/