In-Reply-To: <1143016837.2955.20.camel@laptopd505.fenrus.org>
References: <20060322063040.960068000@sorel.sous-sol.org> <20060322063801.949835000@sorel.sous-sol.org> <1143016837.2955.20.camel@laptopd505.fenrus.org>
Mime-Version: 1.0 (Apple Message framework v623)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <1992b724e8540f8e532806076d07eb9e@cl.cam.ac.uk>
Content-Transfer-Encoding: 7bit
Cc: virtualization@lists.osdl.org, Ian Pratt <ian.pratt@xensource.com>,
       xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
       Chris Wright <chrisw@sous-sol.org>
From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Subject: Re: [RFC PATCH 26/35] Add Xen subarch reboot support
Date: Wed, 22 Mar 2006 10:22:46 +0000
To: Arjan van de Ven <arjan@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1140
Lines: 28


On 22 Mar 2006, at 08:40, Arjan van de Ven wrote:

>> +static int shutdown_process(void *__unused)
>> +{
>> +	static char *envp[] = { "HOME=/", "TERM=linux",
>> +				"PATH=/sbin:/usr/sbin:/bin:/usr/bin", NULL };
>> +	static char *restart_argv[]  = { "/sbin/reboot", NULL };
>> +	static char *poweroff_argv[] = { "/sbin/poweroff", NULL };
>
> how is this function different from the generic one? If not, why aren't
> you using the generic one?

The intent is to allow remote management tools to trigger a clean 
shutdown of the virtual machine. That requires us to notify to 
userspace, and this function does that by exec'ing one of the standard 
userspace programs. Given the trigger is received by the kernel in the 
first instance I don't know a better way of doing this. And if this is 
the best way, I don't think there is generic code in the kernel which 
does the same thing.

  -- Keir

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/