Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp813001ybg; Tue, 9 Jun 2020 13:34:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuHXTBOOMYSt2k4RhA9otGTdFBrIHM8Mx4ev/iVHFe7htDce+cxF/ALHIJFNfAemb5A0lM X-Received: by 2002:a17:906:5c0a:: with SMTP id e10mr147323ejq.389.1591734867450; Tue, 09 Jun 2020 13:34:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591734867; cv=none; d=google.com; s=arc-20160816; b=Ct1fEgQVpY8juVhb6vR1aMKneiujvVSHgr+tDfUQK0ekElkjnuwulYyCBD//MRrCaq 5uOzESsB70aCqW+VFzivpK6Id590K38s3hiPuEJFATNMQotnttj0+3ThviEux6yFRM1d kIdJiW/V8Wu+LILf7zyRw3L1wC98ZFv1QY8XYQQuX6Z8oBoykrzniOYZitKTjBO4X7Ds 3Vns0DS3ZAec1EsOf/9Y0nvf6QW7WKeIYDAruorVPf9b7SN0lGQWGvhWMM4mjfVT8ELD AlXP8QxGW9zfy9uTlzYGpXRlycOk13Hpz5644NG8salGZVyOD0Vn5xCrdzBptlb2b3zT LIjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=j2PL+pbfi1kh+J0AmLH2dyW1hfo8dchWmGFi/N5y4y0=; b=qqDtxLxnW1/qTl+OuoZQ2nLEo2eZl7NAkW7f+CqOSCcraSjYXWJx2AV4BpYDCXFQ0V 0BTOsTVFOhxCuY6Lw6Vk+u0eMplhU8O5vJeFjobI3QfN0MklaTrl9FGLK7d0YqIq/EPZ LxDuvuXhZ4R4n9NmzMKHSdpjFPoqPLrXEB6kbeVytIVW5Rv7kWWOdZLkOlHxmr2w0SIL w3oeEr7Ml71UQC64bFrs17QhgUjRjZACNG4Pv724+KYYvfXsyhR1xo+lc1HUPlUqSxVS QcKnphL0QeMCJlwFJz91OI55ickqb7LBhbs9LCIUOv+9NBm7UzHz009k5753kGuezC/l tRQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=doetDBC8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m21si5130366eds.234.2020.06.09.13.34.04; Tue, 09 Jun 2020 13:34:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=doetDBC8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730516AbgFISsM (ORCPT + 99 others); Tue, 9 Jun 2020 14:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726803AbgFISsL (ORCPT ); Tue, 9 Jun 2020 14:48:11 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1514C05BD1E for ; Tue, 9 Jun 2020 11:48:09 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id s88so1785065pjb.5 for ; Tue, 09 Jun 2020 11:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j2PL+pbfi1kh+J0AmLH2dyW1hfo8dchWmGFi/N5y4y0=; b=doetDBC8GLhAH/GPYh2nF/OZwCESJtT3x/5JwmFQppNQJr5rFhUwRcyR9FtefDzGs1 RdTitQklosNO5HKOvlQUQJc+B3qoYVCfPRU7nKjg3lVc0+kFRfhloN8Q1BIilhESUAsl UifY/flT3XKb72YemuUE0ejI83VnmR69D+rOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j2PL+pbfi1kh+J0AmLH2dyW1hfo8dchWmGFi/N5y4y0=; b=NffjkzdCEsWnBXz4JXvslS9Hrag1jy6LuMjuSs1vRtyJ9OvJVV329dF19bo3I3CS+S gIQ59livHlOT01udOJIy0P+vvLlTnZr9V9lroQSxaceLhldyqmJXTnEc2EPNqrcC95/W 37qcZjiAl6jqGw41D/rbYhph0v4xMdjQYdeo26c9raCjPURZzastDBDctfYTxj3LAPl6 nMyfJZbQm9ZZMg45nN0Zqh67rrjIdJ2WWa6WoBUl/tN+UZl8bZYciiAgNPnRyWcbBFFs GnLuO7+6EVTNAUZ4hds9kKGGcq1VxYmQl4EGRhDEtwwVb/zELLfOqWph1NXwuui06/Og 3deQ== X-Gm-Message-State: AOAM532DVWpw3n43aYeb5y7DN5k74vWJQdDBiMVH1aTHjvlYX6rFtRYV LsrEhMuCIyR7N/it4nMAISMlrg== X-Received: by 2002:a17:90a:2647:: with SMTP id l65mr6474171pje.20.1591728489562; Tue, 09 Jun 2020 11:48:09 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j13sm3223850pje.25.2020.06.09.11.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 11:48:08 -0700 (PDT) Date: Tue, 9 Jun 2020 11:48:07 -0700 From: Kees Cook To: Alexander Popov Cc: Emese Revfy , Miguel Ojeda , Masahiro Yamada , Michal Marek , Andrew Morton , Masahiro Yamada , Thiago Jung Bauermann , Luis Chamberlain , Jessica Yu , Sven Schnelle , Iurii Zaikin , Catalin Marinas , Will Deacon , Vincenzo Frascino , Thomas Gleixner , Peter Collingbourne , Naohiro Aota , Alexander Monakov , Mathias Krause , PaX Team , Brad Spengler , Laura Abbott , Florian Weimer , kernel-hardening@lists.openwall.com, linux-kbuild@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gcc@gcc.gnu.org, notify@kernel.org Subject: Re: [PATCH 4/5] gcc-plugins/stackleak: Don't instrument itself Message-ID: <202006091147.1B8E3ABE@keescook> References: <20200604134957.505389-1-alex.popov@linux.com> <20200604134957.505389-5-alex.popov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200604134957.505389-5-alex.popov@linux.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 04, 2020 at 04:49:56PM +0300, Alexander Popov wrote: > There is no need to try instrumenting functions in kernel/stackleak.c. > Otherwise that can cause issues if the cleanup pass of stackleak gcc plugin > is disabled. > > Signed-off-by: Alexander Popov Acked-by: Kees Cook -- Kees Cook