Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Jun 2020 14:52:07 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Matt Helsley <mhelsley@vmware.com>
Cc:     Julien Thierry <jthierry@redhat.com>,
        <linux-kernel@vger.kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Sami Tolvanen <samitolvanen@google.com>,
        Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: Re: [RFC][PATCH v4 02/32] objtool: Make recordmcount into mcount
 subcmd
Message-ID: <20200609145207.1d9dafa2@oasis.local.home>
In-Reply-To: <20200609183951.GE1284251@rlwimi.vmware.com>
References: <cover.1591125127.git.mhelsley@vmware.com>
        <0d44e0b1b8ebce4af8b90f73e351a003ef016005.1591125127.git.mhelsley@vmware.com>
        <fe3e0e4e-4f13-5193-c684-f995c8310e54@redhat.com>
        <20200609183951.GE1284251@rlwimi.vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 9 Jun 2020 11:39:51 -0700
Matt Helsley <mhelsley@vmware.com> wrote:

> > > +ifeq ($(SRCARCH),sparc)
> > > +	SUBCMD_MCOUNT := y  
> > 
> > Is there some arch for which MCOUNT is not supported? If not you could just
> > have MCOUNT default to 'y' and avoid adding all those tests (or maybe reduce
> > the numbers and set to 'n' only for arches not supporting it).  
> 
> Yes, there are some which it does not support. For those architectures
> we keep recordmcount.pl around.
> 
> It occured to me that with your suggestion to use more CONFIG_ variables
> we could eliminate this pattern and replace it with these pseudo-patches:
> 
> +++ b/kernel/trace/Kconfig
> 
> +config OBJTOOL_SUBCMD_MCOUNT
> +	bool
> +	depends on HAVE_C_RECORDMCOUNT
> +	select OBJTOOL_SUBCMDS
> +	help
> +	  Record mcount call locations using objtool
> 
> and then change the Makefiles to use the CONFIG_ variables
> rather than have one ifeq block per arch:
> 
> +++ b/tools/objtool/Makefile
> 
> +SUBCMD_MCOUNT := $(CONFIG_OBJTOOL_SUBCMD_MCOUNT)

If you can make this work, this is definitely the way to go.

-- Steve

> 
> Does this seem like a good use of CONFIG_ variables or is it going too
> far?
> 
> I haven't changed to this pattern just yet -- I'm hoping you and Josh
> or Peter might weigh in with your preferences.