Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Leo Li <leoyang.li@nxp.com>
To:     Hui Song <hui.song_1@nxp.com>,
        "linux-devel@linux.nxdi.nxp.com" <linux-devel@linux.nxdi.nxp.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        Hui Song <hui.song_1@nxp.com>
Subject: RE: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
Thread-Topic: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
Thread-Index: AQHWPkPJIX2y5uVvV0i+EVd9iXRd3qjQsZ0w
Date:   Tue, 9 Jun 2020 19:51:43 +0000
Message-ID: <VE1PR04MB66874A7F9C037E5F9C3A99FB8F820@VE1PR04MB6687.eurprd04.prod.outlook.com>
References: <20200609093741.44050-1-hui.song_1@nxp.com>
In-Reply-To: <20200609093741.44050-1-hui.song_1@nxp.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0dbb603f-908a-44a7-d35d-08d80cae8947
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2020 19:51:43.8194
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WAG+PeNtOtE/UaZHafbs1v8z355eEtJVVw35IAukvz8vngqxENMw7o5QoPoks574k4mPYdgvd60u76RYU1qi6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6559
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Hui Song <hui.song_1@nxp.com>
> Sent: Tuesday, June 9, 2020 4:38 AM
> To: linux-devel@linux.nxdi.nxp.com; Shawn Guo <shawnguo@kernel.org>;
> Leo Li <leoyang.li@nxp.com>; Rob Herring <robh+dt@kernel.org>; Mark
> Rutland <mark.rutland@arm.com>; Linus Walleij <linus.walleij@linaro.org>;
> Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; lin=
ux-
> kernel@vger.kernel.org; linux-gpio@vger.kernel.org; Hui Song
> <hui.song_1@nxp.com>
> Subject: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
>=20
> From: Song Hui <hui.song_1@nxp.com>
>=20
> delete the interrupt IRQF_NO_THREAD flags.

I think this is the correct direction but would be better to describe a lit=
tle bit on what motived this change.  Any issue encountered or latency opti=
mization?

>=20
> Signed-off-by: Song Hui <hui.song_1@nxp.com>
> ---
>  drivers/gpio/gpio-mpc8xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c in=
dex
> 604dfec..1e86652 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device
> *pdev)
>=20
>  	ret =3D devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
>  			       mpc8xxx_gpio_irq_cascade,
> -			       IRQF_NO_THREAD | IRQF_SHARED, "gpio-
> cascade",
> +			       IRQF_SHARED, "gpio-cascade",
>  			       mpc8xxx_gc);
>  	if (ret) {
>  		dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d),
> ret =3D %d\n",
> --
> 2.9.5