Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp817756ybg; Tue, 9 Jun 2020 13:42:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4X8FpNqagRvL2ZT9/lyrKrcBsJ0dCRJ2bjzlkcSlI6fhJkP9iveERNCWGAIq62kREdBr6 X-Received: by 2002:a17:906:d9dc:: with SMTP id qk28mr221594ejb.6.1591735352588; Tue, 09 Jun 2020 13:42:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591735352; cv=none; d=google.com; s=arc-20160816; b=iAJfL/BTIeQ3VszXYaKdQMmzqrz6cbinUTEgxO24riqLN3JOhZ9A2D6x29YCfocLZe Gw5hwBVon3O9XrZ5+ZLrcXX8LLytTGfIRM1o5ev66uNangPXVPyhSfsUTXTHUBRYHppJ iKKkiO3+FXbr5AdIVlmwxnVTiHe0Ub4Izyecek/pgDR0a/ysjjtEEfLnwMBPDdGF9dbG 6AThwH3jP6jufTA6BLxpZsHMINUlsLE8dCX2yxkdF2uf/PHoMe50DjYOZoqAzpZfio5l EzRrlXQG1HW6M0fPAUdP4paw+ExDbF6iEJ1S6vra6y1h5DZGHE//KKVvt6t/zZjgqBya WtaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=9JYzHVam3aoxA7E3Nf+mPqLW8Cnq9QYwGHyougBUIUM=; b=eRJvBLEC7HYpPyua0cfBsqZK8+n5TG3FijkNuNFYGpRz841wsr7bA1p/jogxjO0lvY CpOIVvG2XztE4so7K17YexHhdgjE7+sVHieX94HI655Gr12MMIsg1mdRwTH08HeM7dyw lWK4btJB+UvTZIJo1yy0IdKpFHh5CWaI6ORCvBcX1fe0lot5C7R8SNPVNZ7XD9H73Mrm 7XXB+ljuO070+S46SZj9Zko3hK5wgbtNPCF/KTIwuuTvjdDQCYe6U2gFp0TO/TfWJYRG qveJDCRk2YjPgvk5CR+kELUpRlrHzag11sclK1KVy9nlVpzttXgBLDqi/S2t1qOxkkAB SJBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=AUTUaWX5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x15si12055404edq.90.2020.06.09.13.42.09; Tue, 09 Jun 2020 13:42:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=AUTUaWX5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731735AbgFIT7K (ORCPT + 99 others); Tue, 9 Jun 2020 15:59:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbgFIT7I (ORCPT ); Tue, 9 Jun 2020 15:59:08 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5C1CC03E97C for ; Tue, 9 Jun 2020 12:59:07 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id s88so1862929pjb.5 for ; Tue, 09 Jun 2020 12:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9JYzHVam3aoxA7E3Nf+mPqLW8Cnq9QYwGHyougBUIUM=; b=AUTUaWX5mOdyWQvV9aN3Fs0Fise7Hqja4tWkV/PiRtUIxNvqLKLYiphFbWB7b/O6aO uTR5rgofmlKNCQOkMsJaV6qZKZ2Gp+SxhXIoDMZPSsdV235fIHAuLEULkHuqXXrY1a17 msFy9ZV9xEoWbKlBjUrq75XEbUgFscR2TyaC9FxQUDaJC+dDXdbPUGxnWd+UTif5RKF1 8kwGGgfPh7GOQCiHqMDZd6KdYBbJWbibjNxQGA8YcQKBG7yjZdqz3GVDh61izcnneGGz EEcoQys1jUziFulDUbSmEfzY5XN054YMd5xR2VOnw9mB/ddLUI0nPhhAv/TI0tbUZ20P LteA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9JYzHVam3aoxA7E3Nf+mPqLW8Cnq9QYwGHyougBUIUM=; b=pbnhCrAcQoAS7HSunC/sIS5LHJ39EASww3oCFoJ2y0JnbJfPgLFv5dRjkQ/02AIO0D UGGrdEThh7zYOwrXVSzGHxgP3wpLVoBS9YY3iYSK2B0v9Rzq8ioeryVSa9cYhZaljhHq 5shhDYenufV1/H43HKByW6ho8Z1WsAyIWDJTuK96LzgLsKxYKBFM8WNx9ADLwHdcuieg 0wjSsUSA7H9VkpkM+EUpfUkLexJ07/jXj64R/+EHvRUmZp93i170aiP8ql3EfS2PsjGj lEde6Rz0WKQtQw5PuyGCfTAABpQd227hupLLFjlaXEZpGLyRU1UYL0v4clRfr/L8xcGg oAVg== X-Gm-Message-State: AOAM530xk5kITD7QPmMpbmBZnargQzzB2BFJTXXfehgvpBgkAhfpoPKe lEfyhCBRqz/0XWnGs21/BJXI81AHl6WqJnR//342yg== X-Received: by 2002:a17:902:8d97:: with SMTP id v23mr12174plo.297.1591732746497; Tue, 09 Jun 2020 12:59:06 -0700 (PDT) MIME-Version: 1.0 References: <20200607215715.90981-1-rikard.falkeborn@gmail.com> In-Reply-To: <20200607215715.90981-1-rikard.falkeborn@gmail.com> From: Brendan Higgins Date: Tue, 9 Jun 2020 12:58:55 -0700 Message-ID: Subject: Re: [PATCH] kunit: kunit_config: Fix parsing of CONFIG options with space To: Rikard Falkeborn Cc: "open list:KERNEL SELFTEST FRAMEWORK" , Masahiro Yamada , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 7, 2020 at 2:57 PM Rikard Falkeborn wrote: > > Commit 8b59cd81dc5e ("kbuild: ensure full rebuild when the compiler is > updated") introduced a new CONFIG option CONFIG_CC_VERSION_TEXT. On my > system, this is set to "gcc (GCC) 10.1.0" which breaks KUnit config > parsing which did not like the spaces in the string. > > Fix this by updating the regex to allow strings containing spaces. > > Fixes: 8b59cd81dc5e ("kbuild: ensure full rebuild when the compiler is updated") > Signed-off-by: Rikard Falkeborn Reviewed-by: Brendan Higgins Thanks for the patch! I had been meaning to send out a fix for this for a while, but never got around to it. :-)