Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp826281ybg; Tue, 9 Jun 2020 13:58:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzh+4uvR7fJFf8dA3zuWnhgT3dS/zpBjwWus4Hy5e53AqOZfEPnmZPtgKEJjlDIbduPHf18 X-Received: by 2002:aa7:dc58:: with SMTP id g24mr30305683edu.136.1591736319841; Tue, 09 Jun 2020 13:58:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591736319; cv=none; d=google.com; s=arc-20160816; b=xaaLFrkPqouxH90l2tnXkE72ZdpJUq92dyJKT19gDQeAmWMoncqyW7//Dk/KDaz5vm NxJ626xqGN0rxzVZVAa/4qqAzedh7m7lJO3Z5t0cUCMvsHBOR5k5U5mbe1E7LYw0oy0y 5qYChKXZKQ5LjQEsRMATPb2V0ABIssQSPXJldM/dxN+qi46+Utatr1PuaYYJGYpoTdl9 p/6eBjF8DCjsrAotCMmf4J2jVnQGRVJhqLmMyFFj20qpzBnkQ2U8nCRX4Lzt9J4/Ak/E ChW5IdSpC/FvA+wyVbwPl9KwvFHKilJUUt4hCRaD+2R4awkM/f17R/jmN+bCpA+aW4o2 yF8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rcXrhOMWZn0mlJSGDvPjU4sf2BowZe2aY23WBkIK1Bk=; b=nI+CweCEA+1+Do7Dv+IuPcXO2cnzAWmRLmkLQ1CMmbTnG4dAb7VhIyDGP4yjP3PzgF sgLv5rTzhJr54sjFURRkRu1fqTm7/4d0X+0GS72ltsJN3WeFrwNCvRiqRW6Y5VEhI0ve 8bJKEIKUDKb5XhcvVYD6fcvPFkpSedNSNKKg+yGgHOmeQThOPPhABABf37Bf5PKRxM3M jChWtOQMWAXFfTLgcVJOy51pV4QwcWhcMSUEtJ9E6Yzd0Lqh+cHmrBLMmhDUGbI27GPs w933OVUreGV9AvJxtCbuwpG+mWxwuFi5xLheZKe73k3CeNRI72DnsNhaLaoulHdWyrXq 86Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mwnljX3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si10821124ejz.752.2020.06.09.13.58.14; Tue, 09 Jun 2020 13:58:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mwnljX3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728472AbgFIRzY (ORCPT + 99 others); Tue, 9 Jun 2020 13:55:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:44632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729780AbgFIRxc (ORCPT ); Tue, 9 Jun 2020 13:53:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E315D207C3; Tue, 9 Jun 2020 17:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591725212; bh=ViZa30ypR7/xokQKb3odmSsdv+h/Zb0AyqQm1aaQY/s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mwnljX3Q1iclmZQz29HZTBLKgU+Xn933AFtQeFUXy7EbzL0W5MTN2jqufNQNXYNKr I2ex/UI07/IP+xdGx904kAFkX4EsUWoMhlzjsaEL0EWCUkPZ2HdX8EXeqIqhNGcS0A cs0wsi8DoFSEltqSpT4bYzOLmsaAfKycgSWrsJuY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Fugang Duan , "David S. Miller" Subject: [PATCH 5.6 06/41] net: stmmac: enable timestamp snapshot for required PTP packets in dwmac v5.10a Date: Tue, 9 Jun 2020 19:45:08 +0200 Message-Id: <20200609174112.719785772@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200609174112.129412236@linuxfoundation.org> References: <20200609174112.129412236@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fugang Duan [ Upstream commit f2fb6b6275eba9d312957ca44c487bd780da6169 ] For rx filter 'HWTSTAMP_FILTER_PTP_V2_EVENT', it should be PTP v2/802.AS1, any layer, any kind of event packet, but HW only take timestamp snapshot for below PTP message: sync, Pdelay_req, Pdelay_resp. Then it causes below issue when test E2E case: ptp4l[2479.534]: port 1: received DELAY_REQ without timestamp ptp4l[2481.423]: port 1: received DELAY_REQ without timestamp ptp4l[2481.758]: port 1: received DELAY_REQ without timestamp ptp4l[2483.524]: port 1: received DELAY_REQ without timestamp ptp4l[2484.233]: port 1: received DELAY_REQ without timestamp ptp4l[2485.750]: port 1: received DELAY_REQ without timestamp ptp4l[2486.888]: port 1: received DELAY_REQ without timestamp ptp4l[2487.265]: port 1: received DELAY_REQ without timestamp ptp4l[2487.316]: port 1: received DELAY_REQ without timestamp Timestamp snapshot dependency on register bits in received path: SNAPTYPSEL TSMSTRENA TSEVNTENA PTP_Messages 01 x 0 SYNC, Follow_Up, Delay_Req, Delay_Resp, Pdelay_Req, Pdelay_Resp, Pdelay_Resp_Follow_Up 01 0 1 SYNC, Pdelay_Req, Pdelay_Resp For dwmac v5.10a, enabling all events by setting register DWC_EQOS_TIME_STAMPING[SNAPTYPSEL] to 2’b01, clearing bit [TSEVNTENA] to 0’b0, which can support all required events. Signed-off-by: Fugang Duan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -630,7 +630,8 @@ static int stmmac_hwtstamp_set(struct ne config.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT; ptp_v2 = PTP_TCR_TSVER2ENA; snap_type_sel = PTP_TCR_SNAPTYPSEL_1; - ts_event_en = PTP_TCR_TSEVNTENA; + if (priv->synopsys_id != DWMAC_CORE_5_10) + ts_event_en = PTP_TCR_TSEVNTENA; ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA; ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA; ptp_over_ethernet = PTP_TCR_TSIPENA;