Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp62858ybg; Tue, 9 Jun 2020 16:26:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJD9NQoe/z0/0MMeGC9i+SU9HQz/80/s7+0+Jl6ANrEOjKBN1pMoEgbrZhsgs76M+ibwP8 X-Received: by 2002:a17:906:b293:: with SMTP id q19mr735240ejz.412.1591745167414; Tue, 09 Jun 2020 16:26:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591745167; cv=none; d=google.com; s=arc-20160816; b=l6BCNzy5LYSJsBiMZNIk6Cj5yjxoN9+ag+uQiZj8WO8HuObj0ZILGtE4EHMCY5GshW 06ZsY+y0g2OZFj3vg4AbvTjT728YTCdjH6lMvv1kkNcqS1NoS0S4fhKI/2veOZB479zW fIOIs9qKyS1wDNcd6M3W8irPE+bptqzRkgRQW4ACGHx3qJhMvjHfa9RLCPn87XGVfUZn GzkC2Zvj+ZFf9+RSiaVGrWhlB6bjW24vsXLFZLz7wbFZKQRZ5eLgms0sgICl4uZlm5ze 23rE3QgK+lQjubK+nMgAtRswXmfCnbfwjzrrwE1LDkP0r5wIEF57rjfuoJHs/0aIWHDs /5Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=N55IU0Xobsp3AD+X+UPJA3q8baNc4/1TtwSA9QBK+Mc=; b=B3pWc3b4ezdyA4BHMYfghkKjOqUaZvvYW4m2J/h+cxukqlRpwILBKcoYCkP/B4G60n Gl6L2lyG5+VrPBWCiIJ5n25r1z5TpLtNSYxO1UwlAHp2ymps1C8k33O5aUwJwcOxJZEc 7OVHaxZcPEObqEdtvvcw4NLRVgt3CgNqLik50gqLpCIaUJk8HED36TrDGa3yUMMFk4xz 5av8Nx74/t2MjlqcrmHyXmLr04pUG37y60W1g1TYHWgNx242Ur+SkL2EYZf8v0uW5psV fzved88Lqpl5WuStJHvjuidNc8sLiKgjGAy9+ujhfuxPTrx6RFjFphCTFLxEOliGE98p ER0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s12si5008282eju.110.2020.06.09.16.25.44; Tue, 09 Jun 2020 16:26:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725911AbgFIXWE (ORCPT + 99 others); Tue, 9 Jun 2020 19:22:04 -0400 Received: from www62.your-server.de ([213.133.104.62]:56018 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbgFIXWE (ORCPT ); Tue, 9 Jun 2020 19:22:04 -0400 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jinZ8-0008AV-RG; Wed, 10 Jun 2020 01:21:58 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jinZ8-000KbJ-FH; Wed, 10 Jun 2020 01:21:58 +0200 Subject: Re: [PATCH] libbpf: Define __WORDSIZE if not available To: Arnaldo Carvalho de Melo Cc: Alexei Starovoitov , Andrii Nakryiko , Peter Zijlstra , Ian Rogers , Namhyung Kim , Pekka Enberg , Jiri Olsa , Irina Tirdea , bpf , Linux Kernel Mailing List References: <20200608161150.GA3073@kernel.org> <20200609153445.GF24868@kernel.org> <20200609211653.GI24868@kernel.org> From: Daniel Borkmann Message-ID: <6b2630e7-ac41-b6d4-9e6a-41db717d1b29@iogearbox.net> Date: Wed, 10 Jun 2020 01:21:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200609211653.GI24868@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.3/25838/Tue Jun 9 14:50:43 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/20 11:16 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 09, 2020 at 10:37:48PM +0200, Daniel Borkmann escreveu: >> Hey Arnaldo, >> >> On 6/9/20 5:34 PM, Arnaldo Carvalho de Melo wrote: >>> Some systems, such as Android, don't have a define for __WORDSIZE, do it >>> in terms of __SIZEOF_LONG__, as done in perf since 2012: >>> >>> http://git.kernel.org/torvalds/c/3f34f6c0233ae055b5 >>> >>> For reference: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html >>> >>> I build tested it here and Andrii did some Travis CI build tests too. >>> >>> Acked-by: Andrii Nakryiko >>> Signed-off-by: Arnaldo Carvalho de Melo >> >> Diff missing? > > Oh well, sorry about that, EBADCOFFEE or something: > > From: Arnaldo Carvalho de Melo > > Some systems, such as Android, don't have a define for __WORDSIZE, do it > in terms of __SIZEOF_LONG__, as done in perf since 2012: > > http://git.kernel.org/torvalds/c/3f34f6c0233ae055b5 > > For reference: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html > > I build tested it here and Andrii did some Travis CI build tests too. > > Acked-by: Andrii Nakryiko > Signed-off-by: Arnaldo Carvalho de Melo > [...] Applied, thanks!