Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp145604ybg; Tue, 9 Jun 2020 19:05:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBXNC/ANUh4cAp8CN1u95RhTBfD8fwA1Rey0tvrL+SZG02MePnyM7XPpYEz1TQcphV+Pl1 X-Received: by 2002:a50:f9cc:: with SMTP id a12mr563806edq.227.1591754747453; Tue, 09 Jun 2020 19:05:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591754747; cv=none; d=google.com; s=arc-20160816; b=T4+McNUZUe59K98zXhoZtZSiUGP1mN5nXPRwrZHtJje0g+V5RVD+gcQkOS+RH8AGH3 YLobP9zgseQSoDkdzEjgTDz8Rs7JYgMrEdDRHP7Btzid2RW9fCJK+XqgY1kRQvOmfEQy F/qO+2X2A6QSfT75ECQNK2qmAEMxxYJwjfWapcAzf5LN5YZk9VaGZz9xVFLYmPKKZkcr TGhu9XHPKFIFmKy0gy8E3P3APyEzontbQ/S/6+R7G4FiT47Knq6hdBMNGl4rGuVILNJK LJp8G3LIT7dVV2OMCdJiF9Fert92JcU5SkT75ZRU2zkWT/CByoSFwaSaf8wSkDo2CW9c 3OFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QveDZg30MOOAbZTP12jlsSCSngLlZQHSsESF1vrXEKU=; b=Ihi/IIQdCG3fFFM27lUCV6dqcc47MPGR3edluRipKe4bFhr1Zq9GuhksLeKRA04SN2 6axmWIX3Y3ZOykSW/DmEtbao+cxZYgYZ97eK+Bn4xMW3TlUPqEsRuDDh7kRhnAk9Vpfk xfExKIuWeADZ5gfGZIPv1DRdUBkMKw2nN5L+l1SUdxidP+kKnZSmtnVgPveHjj5HmJrk M5C974m7y1oDqThoCXrJw5yC09/HBWz7qhDcwJ42DE9VXXb8T9h80h/BO8oft43899pM B9e0WZ42uEiDTMzyCXDsmicKpg9mdLj0mi1U5/wd5ZOrc/+hZTGqsOGMHYQK1s8diqe3 hROQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=bZi5MJgT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zh8si12024416ejb.92.2020.06.09.19.05.24; Tue, 09 Jun 2020 19:05:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=bZi5MJgT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726084AbgFJCDg (ORCPT + 99 others); Tue, 9 Jun 2020 22:03:36 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42128 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbgFJCDf (ORCPT ); Tue, 9 Jun 2020 22:03:35 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05A22hik102911; Wed, 10 Jun 2020 02:03:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=QveDZg30MOOAbZTP12jlsSCSngLlZQHSsESF1vrXEKU=; b=bZi5MJgTajpxsPHRTMAy7G/kwN8l95bxhTx6V25CFB14JRSQwxUKgJyDZpE/6HbMTU3O wZbzrj/mlp/zOLN3FDYMoJZ/SCuFVhPZrBgdRRfFpOe3UzvEiAsjrc/TNv5FilLD+QGt 2wyfpNHttbkCzHAvcEypaRNBKmnj7VxTzHg4yd+nFBitPguzirQwqYqyxwe5ch7MgFuP eMhpkLbWj8AW3yzbKjqjXi9GLHm03oIBaa0VQuQ3pXgZwIKLhJDpbubrIflZ8dRSBazw YrO0edk1qfR+ARMP8vMb9zdk5KP3rB60yWXMGMl6yMP31wt8Y6tHy6SvrLFSSm5Cjymk BQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 31g3smyr30-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Jun 2020 02:03:03 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05A1vgRs091385; Wed, 10 Jun 2020 02:03:03 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 31gn2xm4t6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jun 2020 02:03:03 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 05A22tGq003331; Wed, 10 Jun 2020 02:03:00 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 09 Jun 2020 19:02:54 -0700 From: "Martin K. Petersen" To: Bart Van Assche , "James E.J. Bottomley" , Simon Arlott , Jens Axboe Cc: "Martin K . Petersen" , Linux Kernel Mailing List , Merlijn Wajer , linux-scsi@vger.kernel.org Subject: Re: [PATCH v2 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy Date: Tue, 9 Jun 2020 22:02:47 -0400 Message-Id: <159175452257.16072.17569880133353520216.b4-ty@oracle.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <06e9de38-eeed-1cab-5e08-e889288935b3@0882a8b5-c6c3-11e9-b005-00805fc181fe> References: <06e9de38-eeed-1cab-5e08-e889288935b3@0882a8b5-c6c3-11e9-b005-00805fc181fe> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9647 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006100013 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9647 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 cotscore=-2147483648 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 mlxlogscore=999 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006100013 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 May 2020 18:58:25 +0100, Simon Arlott wrote: > If the device minor cannot be allocated or the cdrom fails to be > registered then the mutex should be destroyed. Applied to 5.8/scsi-queue, thanks! [1/2] scsi: sr: Fix sr_probe() missing mutex_destroy https://git.kernel.org/mkp/scsi/c/a247e07f8dad [2/2] scsi: sr: Fix sr_probe() missing deallocate of device minor https://git.kernel.org/mkp/scsi/c/6555781b3fde -- Martin K. Petersen Oracle Linux Engineering