Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Avri Altman <avri.altman@wdc.com>
Cc:     kjlu@umn.edu, Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Can Guo <cang@codeaurora.org>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Dinghao Liu <dinghao.liu@zju.edu.cn>
Subject: Re: [PATCH] scsi: ufs-bsg: Fix runtime PM imbalance on error
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1k10fsmaj.fsf@ca-mkp.ca.oracle.com>
References: <20200522045932.31795-1-dinghao.liu@zju.edu.cn>
Date:   Tue, 09 Jun 2020 22:11:27 -0400
In-Reply-To: <20200522045932.31795-1-dinghao.liu@zju.edu.cn> (Dinghao Liu's
        message of "Fri, 22 May 2020 12:59:29 +0800")
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Avri: Please review!

> When ufs_bsg_alloc_desc_buffer() returns an error code,
> a pairing runtime PM usage counter decrement is needed
> to keep the counter balanced.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>  drivers/scsi/ufs/ufs_bsg.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
> index 53dd87628cbe..516a7f573942 100644
> --- a/drivers/scsi/ufs/ufs_bsg.c
> +++ b/drivers/scsi/ufs/ufs_bsg.c
> @@ -106,8 +106,10 @@ static int ufs_bsg_request(struct bsg_job *job)
>  		desc_op = bsg_request->upiu_req.qr.opcode;
>  		ret = ufs_bsg_alloc_desc_buffer(hba, job, &desc_buff,
>  						&desc_len, desc_op);
> -		if (ret)
> +		if (ret) {
> +			pm_runtime_put_sync(hba->dev);
>  			goto out;
> +		}
>  
>  		/* fall through */
>  	case UPIU_TRANSACTION_NOP_OUT:

-- 
Martin K. Petersen	Oracle Linux Engineering