Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
To:     =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= <noltari@gmail.com>,
        mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
        f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
        julia.lawall@lip6.fr, f4bug@amsat.org, jonas.gorski@gmail.com,
        lkp@intel.com, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20200609113049.4035426-1-noltari@gmail.com>
 <20200609113049.4035426-3-noltari@gmail.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <1367fcf3-24ed-9106-a329-da5f8e168e17@gmail.com>
Date:   Tue, 9 Jun 2020 19:27:16 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Firefox/68.0 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200609113049.4035426-3-noltari@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
> +	{ .name = "adsl_asb", .bit = 0, },
> +	{ .name = "usb_asb", .bit = 1, },
> +	{ .name = "mips_asb", .bit = 2, },
> +	{ .name = "pcie_asb", .bit = 3, },
> +	{ .name = "phymips_asb", .bit = 4, },
> +	{ .name = "robosw_asb", .bit = 5, },
> +	{ .name = "sar_asb", .bit = 6, },
> +	{ .name = "sdr_asb", .bit = 7, },
> +	{ .name = "swreg_asb", .bit = 8, },
> +	{ .name = "periph_asb", .bit = 9, },
> +	{ .name = "cpubus160", .bit = 10, },
> +	{ .name = "adsl", .bit = 11, },
> +	{ .name = "sar124", .bit = 12, },

Nit: this should be sar125

> +	{ .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
> +	{ .name = "pcie", .bit = 14, },
> +	{ .name = "robosw250", .bit = 16, },
> +	{ .name = "robosw025", .bit = 17, },
> +	{ .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
> +	{ .name = "usb", .bit = 20, },

This should probably be "usbd" to indicate this is the USB device clock
(not host)

With that fixed:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian