Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp205663ybg; Tue, 9 Jun 2020 21:22:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSXQIpSh29eB80PyqFQEKiDWSureRRLXHij3Yr3eYGxXJmrtXDM2881Aj5x2S+FyG2l5mI X-Received: by 2002:a17:906:4d18:: with SMTP id r24mr1519519eju.222.1591762926493; Tue, 09 Jun 2020 21:22:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591762926; cv=none; d=google.com; s=arc-20160816; b=G/plCtqyvFYc3fVGRJpg3CMrQiQbVJkey2yEh76c3f4zK9ccOfOav82EcChdFODfuo eBtSAmKPbAPcfbVjCtiqAyhFJaH51zDK9FxsqAsi/k/p+tYjFz+KlazOl1YYxxCW0kuA ixBelf7C6CRgDaCVsCMw9cGqvGJbvnWTB0MKNdKA7S0oFwNumKLXGH9kuYHM6+GgIbq8 TfHmlR2gVK8y9ls9/InjL9/2I+BQaYdyxvqAGt3JRBi16SEAcoapwmdPuClqUeTq4dSy Vwj2vfXnIZlqLRGU33FTtOfAsAYlBP45CeKSQgufF/Z1EZ9G5U1RLhxp6R5WJwgb4tVL fQew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references; bh=viIqB6wzEb3U3dh8hUkbRQ9Hslg5vHCP1SnglRIck3Y=; b=nusAWVo0X62CAX+ncDB6hPWDhXxRJNLMYqJX/iNlhzmZOdVcyMmIQNGKX9fjN/Bjbp sH6AZgHKx2YC3wiwqrHlsXBHG0yzkHaYL17aSCE28uTnYQDPhLv/Q+COrG1dsmbLsTQG z3tTi0Fi8pZUJXBejhN7bjIpiOjodkC1x3AEGR6V2/8pMqqA46aRmmTPPnWfbWctSWf+ 8/rJBFdeeYgLUE7HNhmyAQW4CTfS6rdq65lTlrakwXnGSxpFXTF7NxJ4YtB7DeDcSIBB QSMd+c7GKJrhDuiZQfytXOKKQpxsfHZAbrOIuLrYXlro/AYPd3KfbKT5YVfim2pakPSf 9V3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k14si11902994ejz.68.2020.06.09.21.21.43; Tue, 09 Jun 2020 21:22:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbgFJETp (ORCPT + 99 others); Wed, 10 Jun 2020 00:19:45 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:53074 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725268AbgFJETp (ORCPT ); Wed, 10 Jun 2020 00:19:45 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05A42QcM023682; Wed, 10 Jun 2020 00:19:41 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 31j4unvm5j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jun 2020 00:19:41 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05A4JRPo001696; Wed, 10 Jun 2020 04:19:40 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03wdc.us.ibm.com with ESMTP id 31gxfkernd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jun 2020 04:19:40 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05A4Jc3225559428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jun 2020 04:19:38 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1889C6057; Wed, 10 Jun 2020 04:19:39 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 150B2C6059; Wed, 10 Jun 2020 04:19:38 +0000 (GMT) Received: from morokweng.localdomain (unknown [9.211.67.12]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTPS; Wed, 10 Jun 2020 04:19:37 +0000 (GMT) References: <20200609113909.17236-1-sathnaga@linux.vnet.ibm.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Thiago Jung Bauermann To: Satheesh Rajendran Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Ram Pai , Sukadev Bhattiprolu , Laurent Dufour Subject: Re: [PATCH] powerpc/pseries/svm: Fixup align argument in alloc_shared_lppaca() function In-reply-to: <20200609113909.17236-1-sathnaga@linux.vnet.ibm.com> Date: Wed, 10 Jun 2020 01:19:35 -0300 Message-ID: <871rmneenc.fsf@morokweng.localdomain> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-09_14:2020-06-09,2020-06-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 cotscore=-2147483648 mlxlogscore=677 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006100026 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Satheesh Rajendran writes: > Argument "align" in alloc_shared_lppaca() function was unused inside the > function. Let's fix it and update code comment. > > Cc: linux-kernel@vger.kernel.org > Cc: Thiago Jung Bauermann > Cc: Ram Pai > Cc: Sukadev Bhattiprolu > Cc: Laurent Dufour > Signed-off-by: Satheesh Rajendran > --- > arch/powerpc/kernel/paca.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) Nice. I agree it's a good code cleanup. Reviewed-by: Thiago Jung Bauermann -- Thiago Jung Bauermann IBM Linux Technology Center